<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5811#discussion_r1998812415">app/assets/javascripts/application.js</a>:</p>
<pre style='color:#555'>>
// '-' are replaced with '_' in https://github.com/eemeli/make-plural/tree/main/packages/plurals
const pluralizer = plurals[locale.replace(/\W+/g, "_")] || plurals[locale.split("-")[0]];
if (pluralizer) {
- I18n.pluralization[locale] = (count) => [pluralizer(count), "other"];
+ OSM.i18n.pluralization.register(locale, I18n.useMakePlural({ pluralizer: locale }));
</pre>
<p dir="auto">If you want to write this according to i18n-js docs, it should be:</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-c1">OSM</span><span class="pl-kos">.</span><span class="pl-c1">i18n</span><span class="pl-kos">.</span><span class="pl-c1">pluralization</span><span class="pl-kos">.</span><span class="pl-en">register</span><span class="pl-kos">(</span><span class="pl-s1">locale</span><span class="pl-kos">,</span> <span class="pl-v">I18n</span><span class="pl-kos">.</span><span class="pl-en">useMakePlural</span><span class="pl-kos">(</span><span class="pl-kos">{</span> pluralizer <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p dir="auto">However that's not the best you can do.</p>
<p dir="auto">English has <code class="notranslate">one</code> / <code class="notranslate">other</code> forms. Some languages have <code class="notranslate">one</code> / <code class="notranslate">few</code> / <code class="notranslate">many</code> forms. Let's suppose that there's a string with <code class="notranslate">count</code> that's not yet translated into such language. First, <code class="notranslate">count</code> goes to the pluralizer and the pluralizer says <em>it has to be <code class="notranslate">many</code> form</em>. The string with <code class="notranslate">many</code> key is looked up and it's missing. Then a fallback to English happens, the string is looked up and it's missing again because English has no <code class="notranslate">many</code> form. The user gets to see an error message instead of any fallback:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/54aff4c3-bfd6-4894-88df-7890cbb9d476">image.png (view on web)</a></p>
<p dir="auto">That's why I wrote the pluralizer wrapper like this for i18n-js v3:</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-v">I18n</span><span class="pl-kos">.</span><span class="pl-c1">pluralization</span><span class="pl-kos">[</span><span class="pl-s1">locale</span><span class="pl-kos">]</span> <span class="pl-c1">=</span> <span class="pl-kos">(</span><span class="pl-s1">count</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-kos">[</span><span class="pl-en">pluralizer</span><span class="pl-kos">(</span><span class="pl-s1">count</span><span class="pl-kos">)</span><span class="pl-kos">,</span> <span class="pl-s">"other"</span><span class="pl-kos">]</span><span class="pl-kos">;</span></pre></div>
<p dir="auto">It has a built-in fallback to <code class="notranslate">other</code> which is going to be present in English. It's not entirely correct because rules for <code class="notranslate">one</code> form can also be different and you sometimes get fallbacks to English <code class="notranslate">one</code> instead of <code class="notranslate">other</code>, but usually it's bearable.</p>
<p dir="auto">The equivalent for i18n-js v4 looks like this:</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-c1">OSM</span><span class="pl-kos">.</span><span class="pl-c1">i18n</span><span class="pl-kos">.</span><span class="pl-c1">pluralization</span><span class="pl-kos">.</span><span class="pl-en">register</span><span class="pl-kos">(</span><span class="pl-s1">locale</span><span class="pl-kos">,</span> <span class="pl-kos">(</span><span class="pl-s1">_</span><span class="pl-kos">,</span> <span class="pl-s1">count</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-kos">[</span><span class="pl-en">pluralizer</span><span class="pl-kos">(</span><span class="pl-s1">count</span><span class="pl-kos">)</span><span class="pl-kos">,</span> <span class="pl-s">"other"</span><span class="pl-kos">]</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5811#pullrequestreview-2690650937">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJJ3IQF7FHPPPZB5WT2U3JFPAVCNFSM6AAAAABZDZR6OWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOJQGY2TAOJTG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJLYYQ3BMYFAYEWJWD2U3JFPA5CNFSM6AAAAABZDZR6OWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVAMAJTS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5811/review/2690650937</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5811#pullrequestreview-2690650937",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5811#pullrequestreview-2690650937",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>