<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5833#discussion_r2007654594">app/assets/javascripts/heatmap.js</a>:</p>
<pre style='color:#555'>> @@ -59,9 +60,10 @@ document.addEventListener("DOMContentLoaded", () => {
},
scale: {
color: {
- type: "threshold",
+ type: "sqrt",
+ // reverse mutates the array. But with theme changes we must work on the original data.
</pre>
<p dir="auto">What does this comment say?</p>
<p dir="auto">If we need to stop contributors from trying <code class="notranslate">rangeColors.reverse()</code> <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1923048595" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5402/hovercard">again</a> and again, we can have two different <code class="notranslate">rangeColors</code> arrays defined earlier. Maybe the colors in them also need to be different, not just reversed.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5833#pullrequestreview-2706077318">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP7H72UJXSGLJ26FJL2VQL4ZAVCNFSM6AAAAABZPNPX32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMBWGA3TOMZRHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMSILTQ62UYDLKDZHL2VQL4ZA5CNFSM6AAAAABZPNPX32WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVBJN3IM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5833/review/2706077318</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5833#pullrequestreview-2706077318",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5833#pullrequestreview-2706077318",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>