<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4872#discussion_r2007195678">app/views/changesets/_paging_nav.html.erb</a>:</p>
<pre style='color:#555'>> +<% if pages.page_count == 1 %>
+ <h4 class="fs-5">
+ <%= t ".#{type.pluralize}_title" %>
+ <span class="badge count-number">
+ <%= pages.item_count %>
+ </span>
+ </h4>
+<% elsif pages.page_count > 1 %>
+ <h4 class="fs-5">
+ <%= t ".#{type.pluralize}_title" %>
+ <span class="badge count-number">
+ <%= t ".range", :x => pages.current_page.first_item,
+ :y => pages.current_page.last_item,
+ :count => pages.item_count %>
+ </span>
+ </h4>
+
</pre>
<p dir="auto">I'd find a duplicated if easier to read than a duplicated h4.</p>
⬇️ Suggested change
<pre style="color: #555">-<% if pages.page_count == 1 %>
- <h4 class="fs-5">
- <%= t ".#{type.pluralize}_title" %>
- <span class="badge count-number">
- <%= pages.item_count %>
- </span>
- </h4>
-<% elsif pages.page_count > 1 %>
- <h4 class="fs-5">
- <%= t ".#{type.pluralize}_title" %>
- <span class="badge count-number">
- <%= t ".range", :x => pages.current_page.first_item,
- :y => pages.current_page.last_item,
- :count => pages.item_count %>
- </span>
- </h4>
-
+ <h4 class="fs-5">
+ <%= t ".#{type.pluralize}_title" %>
+ <span class="badge count-number">
+ <%= if pages.page_count == 1
+ pages.item_count
+ elsif pages.page_count > 1
+ t(".range", x: pages.current_page.first_item,
+ y: pages.current_page.last_item,
+ count: pages.item_count)
+ end %>
+ </span>
+ </h4>
+<% if pages.page_count > 1 %>
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4872#pullrequestreview-2705300418">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLKAOYE7T57BNQTHZ32VPNEVAVCNFSM6AAAAABIWL4IR2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMBVGMYDANBRHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOA6SDRXJST2HQ2J632VPNEVA5CNFSM6AAAAABIWL4IR2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVBH6N4E.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4872/review/2705300418</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4872#pullrequestreview-2705300418",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4872#pullrequestreview-2705300418",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>