<p dir="auto">Our <code class="notranslate">/changeset/:id</code> and <code class="notranslate">/note/:id</code> pages have comments in the sidebar. Those comments are marked up as list items:</p>
<div class="highlight highlight-text-html-basic" dir="auto"><pre class="notranslate"><span class="pl-kos"><</span><span class="pl-ent">ul</span><span class="pl-kos">></span>
<span class="pl-kos"><</span><span class="pl-ent">li</span> <span class="pl-c1">id</span>="<span class="pl-s">c1</span>"<span class="pl-kos">></span>...<span class="pl-kos"></</span><span class="pl-ent">li</span><span class="pl-kos">></span>
<span class="pl-kos"><</span><span class="pl-ent">li</span> <span class="pl-c1">id</span>="<span class="pl-s">c2</span>"<span class="pl-kos">></span>...<span class="pl-kos"></</span><span class="pl-ent">li</span><span class="pl-kos">></span>
...
<span class="pl-kos"></</span><span class="pl-ent">ul</span><span class="pl-kos">></span></pre></div>
<p dir="auto">Turn out there's a drawback to that: list items redefine text alignment inside them. Normally you wouldn't notice that everything is either left-aligned or right-aligned in case of rtl. But if you want mixed ltr and rtl text inside, you'll have to override <code class="notranslate">text-align</code>. See <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2939421862" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5835" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5835/hovercard?comment_id=2745310604&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/5835#issuecomment-2745310604">#5835 (comment)</a>, see "Add text-align: start; to the mx-2 class CSS." in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2906795084" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5785" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5785/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5785">#5785</a>.</p>
<p dir="auto">Another way to mark up comments is to use <code class="notranslate"><article></code> elements. There are examples of that on <a href="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/article" rel="nofollow">mdn</a> and in the <a href="https://html.spec.whatwg.org/multipage/sections.html#the-article-element" rel="nofollow">html spec</a>. If we use <code class="notranslate"><article></code>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2939421862" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5835" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5835/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5835">#5835</a> will just need to add <code class="notranslate">dir="auto"</code> to paragraphs without modifying css.</p>
<div class="highlight highlight-text-html-basic" dir="auto"><pre class="notranslate"><span class="pl-kos"><</span><span class="pl-ent">article</span> <span class="pl-c1">id</span>="<span class="pl-s">c1</span>"<span class="pl-kos">></span>
<span class="pl-kos"><</span><span class="pl-ent">article</span> <span class="pl-c1">id</span>="<span class="pl-s">c2</span>"<span class="pl-kos">></span>
...</pre></div>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5837'>https://github.com/openstreetmap/openstreetmap-website/pull/5837</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837/commits/619a8422999acdf0d1acad09a3feb281726868f2" class="commit-link">619a842</a> Put changeset comments in <article> elements</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837/commits/1370741ca929d87714934c9cc8c52780291fe0c3" class="commit-link">1370741</a> Put note comments in <article> elements</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837/files">4 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837/files#diff-9a5f2cb48e3a30fd0197d016bd900f26d7183d6714f3a747613c9cbe4a9c8f9d">app/views/changesets/show.html.erb</a>
(54)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837/files#diff-84d04c9c37a8be927ab1870e6b3c1940f670585b77b8e88c32d6ded35cf87dc7">app/views/notes/show.html.erb</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837/files#diff-6cdb8b8fa44e422834c4815943a8e4933d6d09e4687f338d007daeff1a90daa9">test/controllers/changesets_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837/files#diff-b41a560e061b578bbf13158bf175036a9489241ab69f59137c44d57df9682fa7">test/controllers/notes_controller_test.rb</a>
(20)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5837.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5837.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5837.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5837.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5837">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP3WZ7BSF3X22S6CH32VXY23AVCNFSM6AAAAABZSMFDLGVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2DANZZHA4TQMI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKASE5KQPUETJQ7ABT2VXY23A5CNFSM6AAAAABZSMFDLGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHK6SIIAU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5837</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5837",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5837",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>