<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5302#discussion_r2009143132">app/views/users/show.html.erb</a>:</p>
<pre style='color:#555'>> @@ -139,6 +139,16 @@
       <div class='text-body-secondary'>
         <small>
           <dl class="list-inline">
+            <% if @user.home_location_name && @user.home_location_name.strip.present? %>
</pre>
<p dir="auto">This could just be <code class="notranslate">@user.home_location_name&.strip.present?</code>?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5302#discussion_r2009147365">app/assets/javascripts/home_location_name-endpoint.js</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput, locationNameInput) {
</pre>
<p dir="auto">I don't really get what <code class="notranslate">Endpoint</code> means in this name? Would somethinglike <code class="notranslate">HomeLocationGeocoder</code> be a better name maybe?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5302#discussion_r2009147591">app/assets/javascripts/home_location_name-endpoint.js</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput, locationNameInput) {
+  const endpoint = {
+    dirty: false,
</pre>
<p dir="auto">What does <code class="notranslate">dirty</code> mean here? What is the flag mean to do? This implementing the autofill logic described in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2634795627" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5302" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5302/hovercard?comment_id=1897207842&comment_type=review_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/5302#discussion_r1897207842">#5302 (comment)</a> I think? So maybe <code class="notranslate">autofillName</code> or something would be a better name?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5302#pullrequestreview-2708616016">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNI6LAGMJJJSYFDEVL2V3IX3AVCNFSM6AAAAABRF74QGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMBYGYYTMMBRGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNC4EWXY2YTSBB4EUD2V3IX3A5CNFSM6AAAAABRF74QGWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVBOIZVA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5302/review/2708616016</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5302#pullrequestreview-2708616016",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5302#pullrequestreview-2708616016",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>