<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5844#discussion_r2011365512">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>> @@ -76,11 +76,13 @@ def sanitize(text)
end
def linkify(text, mode = :urls)
- if text.html_safe?
- Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer")).html_safe
- else
- Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer"))
- end
+ link_attr = tag_builder.tag_options(:rel => "nofollow noopener noreferrer")
+ Rinku.auto_link(ERB::Util.html_escape(text), mode, link_attr) do |url|
+ %r{^https?://([^/]*)(.*)$}.match(url) do |m|
</pre>
<p dir="auto">Maybe put the www subdomain check into the regex:</p>
⬇️ Suggested change
<pre style="color: #555">- %r{^https?://([^/]*)(.*)$}.match(url) do |m|
+ %r{^https?://(?:www\.)?([^/]*)(.*)$}.match(url) do |m|
</pre>
<p dir="auto">Otherwise linkify_hosts / linkify_domains could get unwieldy long when including all the domains listed in <a href="//osm.wiki/wiki/Domain_names" rel="nofollow">osm.wiki/wiki/Domain names</a>:</p>
<div class="highlight highlight-source-yaml" dir="auto"><pre class="notranslate"><span class="pl-s">["openstreetmap.com", "openstreetmap.net", "openstreetmaps.org", "openmaps.org", "osm.org"]</span></pre></div>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5844#pullrequestreview-2712466589">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLTRMADVZCXIYQ5TGL2WDO57AVCNFSM6AAAAABZWQDNWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMJSGQ3DMNJYHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLOFQ6LHEPHLGGCMQL2WDO57A5CNFSM6AAAAABZWQDNWOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVBVT2J2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5844/review/2712466589</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5844#pullrequestreview-2712466589",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5844#pullrequestreview-2712466589",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>