<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5842#discussion_r2013004680">app/assets/javascripts/index/note.js</a>:</p>
<pre style='color:#555'>> +        const textarea = content.find("textarea");
+        if (textarea.length) {
+          data.set("text", textarea.val());
+        }
</pre>
<p dir="auto">I guess <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a> wants to say that the OSM API reacts the same to empty <code class="notranslate">text</code> parameters and missing <code class="notranslate">text</code> parameters. Internally it's not true because note comment body is nullable. On the other hand we are unlikely to make a distinction between "" and null when we'll be deciding if what's currently stored as a comment is a real comment or not. And the following line is also ignoring this distinction because the comment model creates a <code class="notranslate">RichText</code> object even for null-comments:</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/blob/f1686b59cd92d2af077d49ef41440bc581016ac8/app/views/api/notes/_note.xml.builder#L30">https://github.com/openstreetmap/openstreetmap-website/blob/f1686b59cd92d2af077d49ef41440bc581016ac8/app/views/api/notes/_note.xml.builder#L30</a></p>
<p dir="auto">This <code class="notranslate">if</code> is always true.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5842#discussion_r2013004680">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOEOEBKJYRM5E3VIS32WHHSJAVCNFSM6AAAAABZWHVPFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMJVGMYTQMJTGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLN7C2E27FJSCS5ZW6D2WHHSJA5CNFSM6AAAAABZWHVPFGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVB3B3XM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5842/review/2715318134</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5842#discussion_r2013004680",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5842#discussion_r2013004680",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>