<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5832#discussion_r2014943766">lib/map_layers.rb</a>:</p>
<pre style='color:#555'>> @@ -3,6 +3,10 @@ def self.full_definitions(layers_filename)
     YAML.load_file(Rails.root.join(layers_filename))
         .reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
         .map do |layer|
+          layer["name"] = I18n.t("site.index.map.base.#{layer['nameId']}")
</pre>
<p dir="auto">Well the long term idea was to use the new lib to remove the untranslated credits in the embed, currently that part of the definitions isn't used at all, showing the LOSM credits instead.</p>
<p dir="auto">But if there's no easy clean way to integrate ruby or to split off the translatable part of the definition object perhaps it should be left in js completely.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5832#discussion_r2014943766">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMBXN4CZ27PCT3DRB32WL4ZPAVCNFSM6AAAAABZPJQHDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMJYGUZTCOJRGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLIJ5NCTF2MGBFULXT2WL4ZPA5CNFSM6AAAAABZPJQHDGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVCBGAUQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5832/review/2718531912</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5832#discussion_r2014943766",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5832#discussion_r2014943766",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>