<p></p>
<p><b>@NeatNit</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5840#discussion_r2015669952">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>> + "dl",
+ # "dd", "dt", # child - since it's similar to a list, it has the same behavior as a list
+
+ "math" # don't know how this ends up, but dir="auto" is probably correct
+ ].each do |name|
+ define_method :"convert_#{name}" do |el, indent|
+ attr_bak = el.attr.dup # can't avoid mutating the attr hash, so make a backup
+ el.attr["dir"] = "auto" unless el.attr.key?("dir") # if by some miracle dir is already defined, don't override it
+ ret = super(el, indent)
+ el.attr.replace(attr_bak) # restore backup
+ ret
+ end
+ end
+
+ # only add dir="auto" to bare links
+ def convert_a(el, indent)
</pre>
<p dir="auto">Yes.</p>
<p dir="auto">טקסט <code class="notranslate">func(arg, 1235, "א")</code> טקסט</p>
<p dir="auto">the codespand should render as: <code class="notranslate">func(arg, 1235, "א")</code></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5840#discussion_r2015669952">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMMIO3WPGPOKDUHXQT2WN5QJAVCNFSM6AAAAABZTMJBMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMJZG44DINRUGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNNIKG7QTFXTMOSJI32WN5QJA5CNFSM6AAAAABZTMJBMKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVCDSPMK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5840/review/2719784645</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5840#discussion_r2015669952",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5840#discussion_r2015669952",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>