<h3 dir="auto">Description</h3>
<p dir="auto">This is an attempt at parametrifying marker colors with <code class="notranslate">currentColor</code> since it has come up in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2902703375" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5764" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5764/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5764">#5764</a>.<br>
Together with optimizing the path geometry, this required rewriting the marker layout to be compatible with partially transparent gradients.<br>
While an even simpler path has been proposed and demonstrated in <a href="https://antonkhorev.github.io/msvgen" rel="nofollow">https://antonkhorev.github.io/msvgen</a>, I was searching for a solution without a sudden change in curvature, which I found by constraining a Bezier curve to a specified slope, 1.92 in this case. (See <a href="//codepen.io/hlfan/pen/OPJOGxg" rel="nofollow">CodePen</a>)</p>
<p dir="auto">Where I had the source colors, I tried to fit the colors to the sources, e.g. for the note markers see this before/after:<br>
<a href="https://github.com/user-attachments/assets/879fcd9b-38ed-4a93-a882-948625a29c2d">image.png (view on web)</a></p>
<p dir="auto">For now, this is only a barebones switch to the new markers, but moving in the direction of <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="54446296" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/872" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/872/hovercard?comment_id=2589899767&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/872#issuecomment-2589899767">#872 (comment)</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="683762438" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2787" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2787/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/2787">#2787</a> or <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="20722115" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/507" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/507/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/507">#507</a></p>
<h3 dir="auto">How has this been tested?</h3>
<p dir="auto">Server side and client/browser side separately, no integration testing though.</p>
<h3 dir="auto">Considerations</h3>
<p dir="auto">For the raster icons where I didn't have the colors, I took them from the note markers, so</p>
<ul dir="auto">
<li>either I need better sources than I could find, or</li>
<li>the dot markers will differ in color a bit more:<br>
<a href="https://github.com/user-attachments/assets/0f7e4a62-f013-437d-b2da-94898e433ea9">image.png (view on web)</a></li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5854'>https://github.com/openstreetmap/openstreetmap-website/pull/5854</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/commits/7c82614ec5611d5489856ca41982afa18c695fe1" class="commit-link">7c82614</a> Collect note marker icon definitions</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/commits/5c441c64885888ad864dc3452b8219798f8a48a6" class="commit-link">5c441c6</a> Inline note markers</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/commits/d0b107805cfee0d61f3594e3ea4859d476c4890e" class="commit-link">d0b1078</a> Inline colored markers</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files">24 files</a>)</p>
<ul>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-52e99c7dd4253c8e98beac8f247fc124bb60c94e20ac1932667fde97aac9b47f">app/assets/images/closed_note_marker.svg</a>
(19)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-f5b0d7b2adc41d7bd720c72851e6dc7d9e80ab3253243ae4e5efba2b5d7773b6">app/assets/images/marker-blue.png</a>
(0)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-ecf58f504f622181e052ce75be21b51f06453fd9b4e849b5836e9a83872631fc">app/assets/images/marker-green.png</a>
(0)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-ac5438beade18c5e0543d1e6bd2234ef80ecd935f4df0ed4cd2ab8630932075b">app/assets/images/marker-red.png</a>
(0)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-c44b1d163971b4494110f2376b5a85eb51c46d5f02405ccb84eda47b36654080">app/assets/images/marker-yellow.png</a>
(0)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-e2f67306ed3e8f421308a16e863a14a5c0853df29dc670d5a76f4bb7cf362a05">app/assets/images/new_note_marker.svg</a>
(15)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-0fbcde2564630968f0381dbb335278dbe0c3e9d75383cc8229ba0702a90a8e26">app/assets/images/open_note_marker.svg</a>
(19)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-720e11d91a0c3a64a70dd6bfad46c242e9f4755b2470797031de5b55ff9a8c5d">app/assets/javascripts/index/directions-endpoint.js</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-8058f2f9c608b200098c52a855b78588f6b3aedce1b96c0fa57b706fa2d9e81c">app/assets/javascripts/index/layers/notes.js</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-08fd2f80528286cf96375b12d81cac98954dee8e6a6899f5f261a127861fdd49">app/assets/javascripts/index/new_note.js</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-8f18485b763264500054435af432745e2a51b4402140728dc4df89024768b71b">app/assets/javascripts/index/note.js</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-f060eef487077b042f45b3a12e7a2cbd54a446f8c744cdb98405a1295430e8b9">app/assets/javascripts/leaflet.map.js</a>
(28)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-a9b88a8a3644f944b9bd54361da588c69fa6a210cf7327194c17895a8ad2b0d6">app/assets/javascripts/osm.js.erb</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-6bf5e2b503c6238cb80234a21524267bec1b1a820855412a5795c6296f11cb89">app/assets/javascripts/user.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-ec635e8918e14ddb395eeb0931b51ec3b0f3df431c87cdbc290119a430395284">app/assets/stylesheets/leaflet-all.scss</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-a893bdff25132b2a60513f4fb74deb7507b568af429e60d05a48c63b7dd95230">app/views/dashboards/_contact.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-e390cd3017ea55a29b03a500b95a0203d99769e74ccc353cd2bd8c2bf058ec63">app/views/dashboards/show.html.erb</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-817dba2c5143873a03a457d1e6bcaecc9b93cf7f7ac388ec2780d67db43f720b">app/views/layouts/_defs_markers.html.erb</a>
(43)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-60b815932a6942ef4da576f75ee4e9b670e2aeb07950b7f8494bdbedb319c8c2">app/views/layouts/_search.html.erb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-eaeaf6b733bc454c8c41be224e85cdca90bc6e0e5bc1f02f9f86315cfc6fafab">app/views/layouts/map.html.erb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-4fe647349351c7492508c788230b91b7f4445d4b821f6781ac7fcfad5e879f21">app/views/notes/index.html.erb</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-a84d1cca2d623b0723501ae5a2b0a79069a78770adea9d583abdd27387937b8f">test/system/account_home_test.rb</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854/files#diff-ae7557bec96421caa001f6f6ba95f142100a052294526cab9bf495ab81d99885">test/system/note_layer_test.rb</a>
(6)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5854.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5854.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5854.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5854.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLITJMA4OIB4EFRK5X32WPF6DAVCNFSM6AAAAABZ4WJVUSVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2TENJXGA4DQOI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI3ZWWXCMMZYPV2AZL2WPF6DA5CNFSM6AAAAABZ4WJVUSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHK77FIBE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5854</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5854",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5854",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>