<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860#discussion_r2019619306">app/assets/javascripts/leaflet.map.js</a>:</p>
<pre style='color:#555'>> @@ -391,13 +391,17 @@ OSM.isDarkMap = function () {
return window.matchMedia("(prefers-color-scheme: dark)").matches;
};
-OSM.getUserIcon = function (url) {
- return L.icon({
- iconUrl: url || OSM.MARKER_RED,
- iconSize: [25, 41],
- iconAnchor: [12, 41],
- popupAnchor: [1, -34],
- shadowUrl: OSM.MARKER_SHADOW,
- shadowSize: [41, 41]
- });
+OSM.getMarker = function ({ icon = "MARKER_RED", shadow = true }) {
+ const height = icon.includes("NOTE") ? 40 : 41;
</pre>
<p dir="auto">Probably including height in the parameters is a better solution. <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2952570889" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5854" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5854/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5854">#5854</a> which I wrote this im mind with would remove that change anyway so I didn't think about that.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860#discussion_r2019619306">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJDINC553CRKSLRO4L2WXLCJAVCNFSM6AAAAABZ636SWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMRXGEYTAMZQGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIWWZRD6WQSK7YKSLD2WXLCJA5CNFSM6AAAAABZ636SWOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVCRRTJ6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5860/review/2727110303</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5860#discussion_r2019619306",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5860#discussion_r2019619306",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>