<p dir="auto">OSM.getUserIcon() was used for much more than just the icons on the user page.<br>
I've made it work with the icon paths already stored in the OSM object and made it compatible with the note icons to eliminate the <code class="notranslate">noteIcons</code> objects.</p>
<p dir="auto">I previously included this in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2952570889" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5854" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5854/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5854">#5854</a>, but I think it makes more sense as a separate PR.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5860'>https://github.com/openstreetmap/openstreetmap-website/pull/5860</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/commits/3f5fb9a200ff0e5e87b4fd38c800bf3a78bc62c7" class="commit-link">3f5fb9a</a>  Consolidate leaflet marker creation in OSM.getMarker</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files">13 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-01d803186412f226455170ecc092c9a0ba9251eb06d82f7e22a3c118582dcb61">app/assets/javascripts/diary_entry.js</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-720e11d91a0c3a64a70dd6bfad46c242e9f4755b2470797031de5b55ff9a8c5d">app/assets/javascripts/index/directions-endpoint.js</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-25ac812e678be24de55edea1d68f9948fc58bf4cee7ae83f6de1fd077a6d2549">app/assets/javascripts/index/home.js</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-8058f2f9c608b200098c52a855b78588f6b3aedce1b96c0fa57b706fa2d9e81c">app/assets/javascripts/index/layers/notes.js</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-08fd2f80528286cf96375b12d81cac98954dee8e6a6899f5f261a127861fdd49">app/assets/javascripts/index/new_note.js</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-8f18485b763264500054435af432745e2a51b4402140728dc4df89024768b71b">app/assets/javascripts/index/note.js</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-8859067d4860f7b3d870155d8af8c81e89fd7c66cd2ebb58bd42cf31005c3c27">app/assets/javascripts/index/search.js</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-f060eef487077b042f45b3a12e7a2cbd54a446f8c744cdb98405a1295430e8b9">app/assets/javascripts/leaflet.map.js</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-a9b88a8a3644f944b9bd54361da588c69fa6a210cf7327194c17895a8ad2b0d6">app/assets/javascripts/osm.js.erb</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-6bf5e2b503c6238cb80234a21524267bec1b1a820855412a5795c6296f11cb89">app/assets/javascripts/user.js</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-a893bdff25132b2a60513f4fb74deb7507b568af429e60d05a48c63b7dd95230">app/views/dashboards/_contact.html.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860/files#diff-e390cd3017ea55a29b03a500b95a0203d99769e74ccc353cd2bd8c2bf058ec63">app/views/dashboards/show.html.erb</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5860.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5860.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5860.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5860.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5860">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJTC7UNOZR6IA4G76D2WTWDLAVCNFSM6AAAAABZ636SWOVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2TKMZQGA4DENA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLN655UDNOA7Q423GZ32WTWDLA5CNFSM6AAAAABZ636SWOWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHLAJSP3A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5860</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5860",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5860",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>