<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5868#discussion_r2020436476">app/assets/javascripts/index/search.js</a>:</p>
<pre style='color:#555'>> + const params = new URLSearchParams;
+ for (const paramName of ["query", "zoom", "minlon", "minlat", "maxlon", "maxlat"]) {
+ const paramValue = this.elements[paramName].value;
+ if (paramValue) {
+ params.set(paramName, paramValue);
+ }
+ }
+ const search = params.get("query") ? `/search?${params}` : "/";
</pre>
<p dir="auto">Do you really want to expose all these parameters in the URL?<br>
The bbox params don't even update the map hash that's also there</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5868#pullrequestreview-2728284278">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNG3UT3IJF7HMGLIA32XDIXBAVCNFSM6AAAAAB2DMF6GCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMRYGI4DIMRXHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJGIQGVBG77AMFOAZ32XDIXBA5CNFSM6AAAAAB2DMF6GCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVCTZIHM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5868/review/2728284278</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5868#pullrequestreview-2728284278",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5868#pullrequestreview-2728284278",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>