<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5863#discussion_r2020725198">app/controllers/geocoder_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -9,14 +9,17 @@ class GeocoderController < ApplicationController
   authorize_resource :class => false
 
   def search
-    @params = normalize_params
+    normalize_params
</pre>
<p dir="auto">This could be a <code class="notranslate">before_action</code> now if we don't need to use the result?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5863#discussion_r2020726930">app/assets/javascripts/index/search.js</a>:</p>
<pre style='color:#555'>> @@ -18,9 +21,14 @@ OSM.Search = function (map) {
   $(".search_form").on("submit", function (e) {
     e.preventDefault();
     $("header").addClass("closed");
-    const query = $(this).find("input[name=query]").val();
-    let search = "/";
-    if (query) search = "/search?" + new URLSearchParams({ query });
+    const params = new URLSearchParams;
+    for (const paramName of ["query", "zoom", "minlon", "minlat", "maxlon", "maxlat"]) {
</pre>
<p dir="auto">If we're going to build the URL in the submit handler why not just add the parameters from the bounding box here instead of adding hidden input fields and an event handler to keep them up to date?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5863#pullrequestreview-2728756323">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKP3PL6GPUN5VSOKM32XEFMDAVCNFSM6AAAAAB2BTP5WGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMRYG42TMMZSGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM3HF75M6EWYMRZ4JL2XEFMDA5CNFSM6AAAAAB2BTP5WGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVCUWCGG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5863/review/2728756323</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5863#pullrequestreview-2728756323",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5863#pullrequestreview-2728756323",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>