<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<blockquote>
<p dir="auto">I'm not sure if this should be part of this PR—maybe we should address the issue in another PR.</p>
</blockquote>
<p dir="auto">Well, I think it's same if we do this now or in next PR (but really next), because we cannot delay this because next steps will be:</p>
<ul dir="auto">
<li>Create versions on <code class="notranslate">reopen</code> / <code class="notranslate">close</code> (where we'll have to set <code class="notranslate">note_version.note_comment_id</code> to <code class="notranslate">note_comment.id</code> which is created on new action)</li>
<li>Generate note versions from <code class="notranslate">note_comments</code> (where we'll copy <code class="notranslate">note_comment.id</code> to <code class="notranslate">note_versions.note_comment_id</code> for every generated note version)</li>
<li>Now we'll be able to do in parallel adding note tags and removing special note comments.</li>
</ul>
<blockquote>
<p dir="auto">Se also the last paragraph of <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2541604426" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5294/hovercard">#5294 (comment)</a>, where I write about keeping <code class="notranslate">id</code> from api0.6-comments. Some of those api0.6-comments will become non-comments and will be deleted from the comments table. In this case their ids are lost. If we are to use them for sorting, we don't need exactly the same ids, anything that forms the same sequence will do.</p>
</blockquote>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/AntonKhorev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/AntonKhorev">@AntonKhorev</a> thanks for this idea! I've just added new column <code class="notranslate">note_comment_id</code> and index on it. I'm only not sure about the new column name (perhaps more natural name would be <code class="notranslate">ordering_id</code> or similar? after removing note comments) and if index should be composite (I still don't have in my head all situations in which new column will be used and how).</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2766013524">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLQTLOYUISKYGBKDLD2XEVDLAVCNFSM6AAAAABZFBY7WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRWGAYTGNJSGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPEKOGOIYQD6LPBCA32XEVDLA5CNFSM6AAAAABZFBY7WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVE3YCFI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5815/c2766013524</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img alt="nenad-vujicic" height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/25298521?s=20&v=4" /><strong>nenad-vujicic</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2766013524">(openstreetmap/openstreetmap-website#5815)</a></div>
<blockquote>
<p dir="auto">I'm not sure if this should be part of this PR—maybe we should address the issue in another PR.</p>
</blockquote>
<p dir="auto">Well, I think it's same if we do this now or in next PR (but really next), because we cannot delay this because next steps will be:</p>
<ul dir="auto">
<li>Create versions on <code class="notranslate">reopen</code> / <code class="notranslate">close</code> (where we'll have to set <code class="notranslate">note_version.note_comment_id</code> to <code class="notranslate">note_comment.id</code> which is created on new action)</li>
<li>Generate note versions from <code class="notranslate">note_comments</code> (where we'll copy <code class="notranslate">note_comment.id</code> to <code class="notranslate">note_versions.note_comment_id</code> for every generated note version)</li>
<li>Now we'll be able to do in parallel adding note tags and removing special note comments.</li>
</ul>
<blockquote>
<p dir="auto">Se also the last paragraph of <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2541604426" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5294/hovercard">#5294 (comment)</a>, where I write about keeping <code class="notranslate">id</code> from api0.6-comments. Some of those api0.6-comments will become non-comments and will be deleted from the comments table. In this case their ids are lost. If we are to use them for sorting, we don't need exactly the same ids, anything that forms the same sequence will do.</p>
</blockquote>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/AntonKhorev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/AntonKhorev">@AntonKhorev</a> thanks for this idea! I've just added new column <code class="notranslate">note_comment_id</code> and index on it. I'm only not sure about the new column name (perhaps more natural name would be <code class="notranslate">ordering_id</code> or similar? after removing note comments) and if index should be composite (I still don't have in my head all situations in which new column will be used and how).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2766013524">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLQTLOYUISKYGBKDLD2XEVDLAVCNFSM6AAAAABZFBY7WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRWGAYTGNJSGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPEKOGOIYQD6LPBCA32XEVDLA5CNFSM6AAAAABZFBY7WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVE3YCFI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5815/c2766013524</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2766013524",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2766013524",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>