<h3 dir="auto">Description</h3>
<p dir="auto">I took another look at the directions engines after <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2974862846" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5898" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5898/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5898">#5898</a>. I may have found too much, but I kept the commit size low this time.</p>
<h3 dir="auto">How has this been tested?</h3>
<p dir="auto">in chrome and firefox</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5901'>https://github.com/openstreetmap/openstreetmap-website/pull/5901</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/367b23db570745e6b80858191eb3787363b779aa" class="commit-link">367b23d</a> Remove TODO fixed in #1439</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/c3e614497b11503f86d5936c304efd92a93d522d" class="commit-link">c3e6144</a> Add instruction index to popup</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/2af72b2e6f4e4c1c0775f16f102f50a59bdeb0c3" class="commit-link">2af72b2</a> Append all turn-by-turn rows together</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/e23d8426a2b6de00292e14d3b20f63868bdc0e3d" class="commit-link">e23d842</a> Remove unused multi-leg logic</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/95685629965360f0901cb5f4755424abfb60e478" class="commit-link">9568562</a> Remove unneeded coordinate reformatting</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/c3ff4dcf5984f877424c300938ea2dc5ac1bb438" class="commit-link">c3ff4dc</a> Split off OSRM getInstructionText function</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/9bb1bed11d5d60de2046ae1bf736d3afe38ee8ac" class="commit-link">9bb1bed</a> Return OSRM instText individually</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/dd8a0f0dff457f27d6c6125a4f724f699d489588" class="commit-link">dd8a0f0</a> Derive popup location from lineseg</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/ce52ba1e6ae4e5ae5fb03e64bde9c7df1dcae4ff" class="commit-link">ce52ba1</a> Simplify step mapping function</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/3262bdfd738d3b9e86099faf8815f6bd0861f22b" class="commit-link">3262bdf</a> Use shorthand property names</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/files">5 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/files#diff-7e2536f2e9b6f209b368993e27a7ecbb60869fc394321af9c2d735c8c02e8fa9">app/assets/javascripts/index/directions/fossgis_osrm.js</a>
(169)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/files#diff-a9cecd581b2c9e4e43ee8e0b73ee178a13779019da8bcb9c13d209843c716711">app/assets/javascripts/index/directions/fossgis_valhalla.js</a>
(46)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/files#diff-ef6651e3e37e12a6ee24e6c9efaa98ddd129a20a5631401cea6e0642fcfffb7a">app/assets/javascripts/index/directions/graphhopper.js</a>
(24)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901/files#diff-081fb5b6a1da6b2f0f153346963554a5195e73fbba65fa8d682b99a8940f88d1">test/system/directions_test.rb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5901.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5901.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5901.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5901.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5901">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJFL5WEUGI6HMM5VNT2YFVDBAVCNFSM6AAAAAB2R6XJOCVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE3TKMJRGE4DMMA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNORMLLH52QVYCH3UT2YFVDBA5CNFSM6AAAAAB2R6XJOCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHLCVE2WQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5901</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5901",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5901",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>