<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<p dir="auto">For additional context: the "icon" in line 137 of <code class="notranslate">external_svg</code> refers to an additional <code class="notranslate">id="icon"</code> I had to add to each of the external svgs, like in this example:</p>
<div class="highlight highlight-text-xml" dir="auto"><pre class="notranslate"><<span class="pl-ent">svg</span> <span class="pl-e">xmlns</span>=<span class="pl-s"><span class="pl-pds">"</span>http://www.w3.org/2000/svg<span class="pl-pds">"</span></span> <span class="pl-e">id</span>=<span class="pl-s"><span class="pl-pds">"</span>icon<span class="pl-pds">"</span></span> <span class="pl-e">width</span>=<span class="pl-s"><span class="pl-pds">"</span>12<span class="pl-pds">"</span></span> <span class="pl-e">height</span>=<span class="pl-s"><span class="pl-pds">"</span>12<span class="pl-pds">"</span></span> <span class="pl-e">viewBox</span>=<span class="pl-s"><span class="pl-pds">"</span>0 0 12 12<span class="pl-pds">"</span></span>></pre></div>
<p dir="auto">I haven't really tested, if it's possible to externalize <code class="notranslate">fill="currentColor"</code> by adding a css class (e.g. education) to the svg:</p>
<pre class="notranslate"><code class="notranslate"> .education {
fill: #39ac39;
}
</code></pre>
<p dir="auto">... and then use "currentColor" instead of "#39ac39".</p>
<p dir="auto">External svgs (rather than inlining) would benefit from browser caching. Downloading lots of small SVGs shouldn't be much of an issue with HTTP/2.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2784431604">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKDPQNQ624INPFFA432YLHG7AVCNFSM6AAAAAB2KIRQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBUGQZTCNRQGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM2GMMTNUMGBKSDALD2YLHG7A5CNFSM6AAAAAB2KIRQGKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVF64G7I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/5880/2784431604</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img alt="mmd-osm" height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/5842757?s=20&v=4" /><strong>mmd-osm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2784431604">(openstreetmap/openstreetmap-website#5880)</a></div>
<p dir="auto">For additional context: the "icon" in line 137 of <code class="notranslate">external_svg</code> refers to an additional <code class="notranslate">id="icon"</code> I had to add to each of the external svgs, like in this example:</p>
<div class="highlight highlight-text-xml" dir="auto"><pre class="notranslate"><<span class="pl-ent">svg</span> <span class="pl-e">xmlns</span>=<span class="pl-s"><span class="pl-pds">"</span>http://www.w3.org/2000/svg<span class="pl-pds">"</span></span> <span class="pl-e">id</span>=<span class="pl-s"><span class="pl-pds">"</span>icon<span class="pl-pds">"</span></span> <span class="pl-e">width</span>=<span class="pl-s"><span class="pl-pds">"</span>12<span class="pl-pds">"</span></span> <span class="pl-e">height</span>=<span class="pl-s"><span class="pl-pds">"</span>12<span class="pl-pds">"</span></span> <span class="pl-e">viewBox</span>=<span class="pl-s"><span class="pl-pds">"</span>0 0 12 12<span class="pl-pds">"</span></span>></pre></div>
<p dir="auto">I haven't really tested, if it's possible to externalize <code class="notranslate">fill="currentColor"</code> by adding a css class (e.g. education) to the svg:</p>
<pre class="notranslate"><code class="notranslate"> .education {
fill: #39ac39;
}
</code></pre>
<p dir="auto">... and then use "currentColor" instead of "#39ac39".</p>
<p dir="auto">External svgs (rather than inlining) would benefit from browser caching. Downloading lots of small SVGs shouldn't be much of an issue with HTTP/2.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2784431604">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKDPQNQ624INPFFA432YLHG7AVCNFSM6AAAAAB2KIRQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBUGQZTCNRQGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM2GMMTNUMGBKSDALD2YLHG7A5CNFSM6AAAAAB2KIRQGKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVF64G7I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/5880/2784431604</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2784431604",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2784431604",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>