<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2037822691">app/assets/javascripts/index/directions-route-output.js</a>:</p>
<pre style='color:#555'>> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance: Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
</pre>
<p dir="auto">Is 1000 still the right boundary to use in feet/miles? It's very different to 1000m in terms of distance... Something like 3280 would be the equivalent, or alternatively 5280 if we wanted to stick to using minor units up to the first major unit.</p>
<p dir="auto">Then again at least in the UK we're more likely to use yards than feet as the minor unit...</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5915#pullrequestreview-2757505165">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK5H567JTJZUGEJ5632Y2MZZAVCNFSM6AAAAAB236JSZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONJXGUYDKMJWGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJ5A5MZHZXJS4VS7R32Y2MZZA5CNFSM6AAAAAB236JSZ6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVELQYI2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5915/review/2757505165</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5915#pullrequestreview-2757505165",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5915#pullrequestreview-2757505165",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>