<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2040677421">app/views/site/fixthemap.html.erb</a>:</p>
<pre style='color:#555'>> +    <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => tag.a(render(:partial => "layouts/note_icon"),
+                                                                                :class => "icon note",
</pre>
<p dir="auto">Well, I do think the icons should only be defined once. In an SVG each, so only the necessary icons are put into the views.<br>
But while <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2967214066" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5880" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5880/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5880">#5880</a> is stalling, would it be ok to define the icons like this?<br>
<a href="https://github.com/openstreetmap/openstreetmap-website/blob/cb0e3d3575da000e9dbbde31bc85efc7a7f66a5d/app/views/layouts/_defs_markers.html.erb#L15-L24">https://github.com/openstreetmap/openstreetmap-website/blob/cb0e3d3575da000e9dbbde31bc85efc7a7f66a5d/app/views/layouts/_defs_markers.html.erb#L15-L24</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2040677421">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN42XV6OP6CTFDWJNL2ZEV2PAVCNFSM6AAAAABYM6ZM26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRSGE4DENRRGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI5KY4FVPRAQUKUCGD2ZEV2PA5CNFSM6AAAAABYM6ZM26WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVEUOH5G.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5752/review/2762182611</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2040677421",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2040677421",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>