<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2040659599">test/system/index_test.rb</a>:</p>
<pre style='color:#555'>> @@ -5,16 +5,16 @@ class IndexTest < ApplicationSystemTestCase
node = create(:node)
visit node_path(node)
assert_selector "#content.overlay-right-sidebar"
- find(".icon.share").click
+ find(".control-share a").click
</pre>
<p dir="auto">If we want tests not failing on intermediate commits, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752/commits/43c3a7cb8b8e5ce96cbcb15b96f679fbb5b7506c">Click links instead of icons in tests</a> should be squashed into <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752/commits/8b59047a1cd593e0b077dc503b0ea3a6461ef472">Unify active control button behaviour</a>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2762165385">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNYPK3F4CFM6C33MLL2ZEJZTAVCNFSM6AAAAABYM6ZM26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRSGE3DKMZYGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOC2BWCCEJDHHEX5ED2ZEJZTA5CNFSM6AAAAABYM6ZM26WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVEUNGIS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5752/review/2762165385</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2762165385",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2762165385",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>