<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5925#discussion_r2041087245">app/assets/javascripts/index/directions/fossgis_osrm.js</a>:</p>
<pre style='color:#555'>> @@ -30,6 +30,7 @@
"rotary": "roundabout",
"exit roundabout": "exit_roundabout",
"exit rotary": "exit_roundabout",
+ "ferry": "continue",
</pre>
<p dir="auto">Shouldn't this be:</p>
⬇️ Suggested change
<pre style="color: #555">- "ferry": "continue",
+ "ferry": "ferry",
</pre>
<p dir="auto">As it stands I get the ferry icon but the text is still just "Continue on..." rather than the new ferry message.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5925#pullrequestreview-2762724289">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPUXWGBW727V5CAPML2ZIXBZAVCNFSM6AAAAAB3AEAKAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRSG4ZDIMRYHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIO2XWI67RHZGQOUAL2ZIXBZA5CNFSM6AAAAAB3AEAKAGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVEVPJ4C.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5925/review/2762724289</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5925#pullrequestreview-2762724289",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5925#pullrequestreview-2762724289",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>