<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<p dir="auto">Technically this looks so I think the main questions here will be whether (a) people think it's a good idea and (b) whether these are the best colour choices.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5924#discussion_r2041091393">app/assets/javascripts/index/history-changesets-layer.js</a>:</p>
<pre style='color:#555'>> @@ -1,15 +1,40 @@
OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
- _changesets: [],
+ newerColor: "#AA8866",
+ olderColor: "#8888AA",
</pre>
<p dir="auto">If we're going to use named constants for these colours shouldn't we do it for the others as well?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5924#pullrequestreview-2762728126">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOXZPWXFLFR3PH657T2ZI2ANAVCNFSM6AAAAAB27N2S6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRSG4ZDQMJSGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLL7NRX4N7R4ZZW76RD2ZI2ANA5CNFSM6AAAAAB27N2S6WWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVEVPRL4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5924/review/2762728126</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5924#pullrequestreview-2762728126",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5924#pullrequestreview-2762728126",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>