<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<blockquote>
<p dir="auto">Why do we need versions to sort comments? Comments already have IDs that can be used for ordering them and deleting some of them doesn't change that - a sequence with gaps is just as ordered as one without them...</p>
</blockquote>
<p dir="auto">Yes, but we want to keep backward compatibility and display (return in JSON / XML) special comments (reconstructed from <code class="notranslate">note_version</code> about closing, reopening, hiding, ..) too even if their body is non-present (like on the screenshot) in appropriate order. If we can abandon these special comments, we wouldn't need <code class="notranslate">note_comment_id</code>.</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/94d38de4-0b65-42f8-ac75-db07e8470df0">image.png (view on web)</a></p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2807611754">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIDPJP5UNSLB4DHL3D2ZV5TNAVCNFSM6AAAAABZFBY7WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGYYTCNZVGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIOZOVCEIUEEFRDW6D2ZV5TNA5CNFSM6AAAAABZFBY7WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVHLDAWU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5815/c2807611754</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/25298521?s=20&v=4" /><strong>nenad-vujicic</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2807611754">(openstreetmap/openstreetmap-website#5815)</a></div>
<blockquote>
<p dir="auto">Why do we need versions to sort comments? Comments already have IDs that can be used for ordering them and deleting some of them doesn't change that - a sequence with gaps is just as ordered as one without them...</p>
</blockquote>
<p dir="auto">Yes, but we want to keep backward compatibility and display (return in JSON / XML) special comments (reconstructed from <code class="notranslate">note_version</code> about closing, reopening, hiding, ..) too even if their body is non-present (like on the screenshot) in appropriate order. If we can abandon these special comments, we wouldn't need <code class="notranslate">note_comment_id</code>.</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/94d38de4-0b65-42f8-ac75-db07e8470df0">image.png (view on web)</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2807611754">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIDPJP5UNSLB4DHL3D2ZV5TNAVCNFSM6AAAAABZFBY7WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGYYTCNZVGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIOZOVCEIUEEFRDW6D2ZV5TNA5CNFSM6AAAAABZFBY7WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVHLDAWU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5815/c2807611754</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2807611754",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2807611754",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>