<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<p dir="auto">Neither.<br>
You already optimized the SVGs when you added them into the templates<sup><a href="#user-content-fn-1-af796495103c981360c20fa8fc50946f" id="user-content-fnref-1-af796495103c981360c20fa8fc50946f" data-footnote-ref="" aria-describedby="footnote-label">1</a></sup>. The additional <code class="notranslate">xmlns</code> is only for increased compatibility during development.<br>
Pulling the SVGs out increases the visualizability (file thumbnails you wouldn't get when they're packed into templates) and supports the <em>separation of concerns</em> raised in the original issue.</p>
<p dir="auto">Just because <em>you</em> understand both SVG internals and layout doesn't mean every contributor should have to.<br>
By keeping them separated, layout edits don’t require SVG expertise, and SVG tweaks won’t accidentally break the layout.</p>
<section data-footnotes="" class="footnotes"><h2 id="footnote-label" class="sr-only" dir="auto">Footnotes</h2>
<ol dir="auto">
<li id="user-content-fn-1-af796495103c981360c20fa8fc50946f">
<p dir="auto">see, e.g., the original <a href="https://github.com/openstreetmap/openstreetmap-website/blob/f9db802c7b2f8ee9582cb2c9f7196d6abafdfced/app/assets/images/new.svg">new.svg</a> <a href="#user-content-fnref-1-af796495103c981360c20fa8fc50946f" data-footnote-backref="" aria-label="Back to reference 1" class="data-footnote-backref">↩</a></p>
</li>
</ol>
</section><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813560815">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPTIYFRRX3TEUKY3HT2Z7M4HAVCNFSM6AAAAAB3LE5BZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJTGU3DAOBRGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOYWGUZI2IAUDT4P5L2Z7M4HA5CNFSM6AAAAAB3LE5BZOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVHWOD66.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5938/c2813560815</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/50826859?s=20&v=4" /><strong>hlfan</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813560815">(openstreetmap/openstreetmap-website#5938)</a></div>
<p dir="auto">Neither.<br>
You already optimized the SVGs when you added them into the templates<sup><a href="#user-content-fn-1-af796495103c981360c20fa8fc50946f" id="user-content-fnref-1-af796495103c981360c20fa8fc50946f" data-footnote-ref="" aria-describedby="footnote-label">1</a></sup>. The additional <code class="notranslate">xmlns</code> is only for increased compatibility during development.<br>
Pulling the SVGs out increases the visualizability (file thumbnails you wouldn't get when they're packed into templates) and supports the <em>separation of concerns</em> raised in the original issue.</p>
<p dir="auto">Just because <em>you</em> understand both SVG internals and layout doesn't mean every contributor should have to.<br>
By keeping them separated, layout edits don’t require SVG expertise, and SVG tweaks won’t accidentally break the layout.</p>
<section data-footnotes="" class="footnotes"><h2 id="footnote-label" class="sr-only" dir="auto">Footnotes</h2>
<ol dir="auto">
<li id="user-content-fn-1-af796495103c981360c20fa8fc50946f">
<p dir="auto">see, e.g., the original <a href="https://github.com/openstreetmap/openstreetmap-website/blob/f9db802c7b2f8ee9582cb2c9f7196d6abafdfced/app/assets/images/new.svg">new.svg</a> <a href="#user-content-fnref-1-af796495103c981360c20fa8fc50946f" data-footnote-backref="" aria-label="Back to reference 1" class="data-footnote-backref">↩</a></p>
</li>
</ol>
</section>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813560815">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPTIYFRRX3TEUKY3HT2Z7M4HAVCNFSM6AAAAAB3LE5BZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJTGU3DAOBRGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOYWGUZI2IAUDT4P5L2Z7M4HA5CNFSM6AAAAAB3LE5BZOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVHWOD66.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5938/c2813560815</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813560815",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813560815",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>