<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<p dir="auto"><strong>@AntonKhorev</strong> seems to have quite a preference for mixing multiple languages and concerns within a single file. Take a look at this <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-2495930790" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5352/hovercard">comment</a> from <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> on another PR of his:</p>
<blockquote>
<p dir="auto">... a massive multi-line block of Ruby embedded in a JS file is definitely not the answer to my mind at least.</p>
</blockquote>
<p dir="auto">Swap out the languages, and we land at this issue here:</p>
<blockquote>
<p dir="auto">... a massive multi-line block of SVG embedded in an ERB file is definitely not the answer ...</p>
</blockquote>
<p dir="auto">The real problem both times is the lack of <em>separation of concerns</em>, which is crucial for maintaining a codebase at scale.<br>
We shouldn’t have to "solve" this by copy-pasting between multiple files or editors, the concerns should be separated from the start, just as they were with the sprites.<br>
This shouldn't be a point of contention.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2813734246">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKYJSLIGQ66YFNS2ZT2Z7XKLAVCNFSM6AAAAAB2KIRQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJTG4ZTIMRUGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKSJ2ICL53AFPNQOOL2Z7XKLA5CNFSM6AAAAAB2KIRQGKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVHWYWWM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/5880/2813734246</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/50826859?s=20&v=4" /><strong>hlfan</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2813734246">(openstreetmap/openstreetmap-website#5880)</a></div>
<p dir="auto"><strong>@AntonKhorev</strong> seems to have quite a preference for mixing multiple languages and concerns within a single file. Take a look at this <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-2495930790" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5352/hovercard">comment</a> from <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> on another PR of his:</p>
<blockquote>
<p dir="auto">... a massive multi-line block of Ruby embedded in a JS file is definitely not the answer to my mind at least.</p>
</blockquote>
<p dir="auto">Swap out the languages, and we land at this issue here:</p>
<blockquote>
<p dir="auto">... a massive multi-line block of SVG embedded in an ERB file is definitely not the answer ...</p>
</blockquote>
<p dir="auto">The real problem both times is the lack of <em>separation of concerns</em>, which is crucial for maintaining a codebase at scale.<br>
We shouldn’t have to "solve" this by copy-pasting between multiple files or editors, the concerns should be separated from the start, just as they were with the sprites.<br>
This shouldn't be a point of contention.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2813734246">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKYJSLIGQ66YFNS2ZT2Z7XKLAVCNFSM6AAAAAB2KIRQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJTG4ZTIMRUGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKSJ2ICL53AFPNQOOL2Z7XKLA5CNFSM6AAAAAB2KIRQGKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVHWYWWM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/5880/2813734246</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2813734246",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2813734246",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>