<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
  <p dir="auto">Updated PR to display how notes versioning, removing special note comments (ones with non-present body which are not "commented") and versioned note tags could look like.</p>
<p dir="auto">Removal of special note-comments (while keeping backward compatibility, i.e. returning same "discussion" with hopefully similar performances) with non-present body is implemented by:</p>
<ul dir="auto">
<li>creating a view which "merges" <code class="notranslate">note_versions</code> and <code class="notranslate">note_comments</code>. I used this approach to keep note comments preloading etc.,</li>
<li>switching <code class="notranslate">.comments</code> and <code class="notranslate">.all_comments</code> associations to point to newly created view, instead of <code class="notranslate">NoteComment</code>,</li>
<li>removing adding special comment if body is not present</li>
<li>running migration script which deletes all special note comments with non-present body.</li>
<li>After this, we should be able to remove <code class="notranslate">event</code> column (still not implemented).</li>
</ul>
<p dir="auto">I would highly appreciate any comment about these changes.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2815829043">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLM4WG47EOWEH6DOJSL22ETZRAVCNFSM6AAAAAB2TRU5CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJVHAZDSMBUGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLN56HYMNQPGP7WZSM322ETZRA5CNFSM6AAAAAB2TRU5CGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVH2YSDG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5904/c2815829043</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>


<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/25298521?s=20&v=4" /><strong>nenad-vujicic</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2815829043">(openstreetmap/openstreetmap-website#5904)</a></div>
<p dir="auto">Updated PR to display how notes versioning, removing special note comments (ones with non-present body which are not "commented") and versioned note tags could look like.</p>
<p dir="auto">Removal of special note-comments (while keeping backward compatibility, i.e. returning same "discussion" with hopefully similar performances) with non-present body is implemented by:</p>
<ul dir="auto">
<li>creating a view which "merges" <code class="notranslate">note_versions</code> and <code class="notranslate">note_comments</code>. I used this approach to keep note comments preloading etc.,</li>
<li>switching <code class="notranslate">.comments</code> and <code class="notranslate">.all_comments</code> associations to point to newly created view, instead of <code class="notranslate">NoteComment</code>,</li>
<li>removing adding special comment if body is not present</li>
<li>running migration script which deletes all special note comments with non-present body.</li>
<li>After this, we should be able to remove <code class="notranslate">event</code> column (still not implemented).</li>
</ul>
<p dir="auto">I would highly appreciate any comment about these changes.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2815829043">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLM4WG47EOWEH6DOJSL22ETZRAVCNFSM6AAAAAB2TRU5CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJVHAZDSMBUGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLN56HYMNQPGP7WZSM322ETZRA5CNFSM6AAAAAB2TRU5CGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVH2YSDG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5904/c2815829043</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2815829043",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2815829043",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>