<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2051719175">app/assets/javascripts/index/directions-route-output.js</a>:</p>
<pre style='color:#555'>> + let distanceUnits = "km";
let downloadURL = null;
- function formatTotalDistance(m) {
- if (m < 1000) {
- return OSM.i18n.t("javascripts.directions.distance_m", { distance: Math.round(m) });
- } else if (m < 10000) {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance: (m / 1000.0).toFixed(1) });
+ function translateDistanceUnits(m) {
+ if (distanceUnits === "km") {
+ return [m, "m", m / 1000, "km"];
} else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance: Math.round(m / 1000) });
+ return [m / 0.3048, "ft", m / 1609.344, "mi"];
}
}
- function formatStepDistance(m) {
- if (m < 5) {
+ function formatTotalDistance(minorValue, minorName, majorValue, majorName) {
+ const scope = "javascripts.directions.distance_in_units";
</pre>
<p dir="auto">If we ignore that what's called a <em>formatter</em> here doesn't format anything, I'm not going to do functions/objects as values of km/mi preference until I decide where I'm storing that preference. Let's suppose the preference is persisted in a cookie. Certainly I'm not going to store a function or an object there.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2051719175">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOFVHJFAG3X4CF6WMT22OK3HAVCNFSM6AAAAAB236JSZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOBQGIZTSOJVGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLITUEGA4ESHY2HIYL322OK3HA5CNFSM6AAAAAB236JSZ6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVFW4ME6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5915/review/2780239951</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2051719175",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2051719175",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>