<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<p dir="auto">This will definitely need some tests - basically cloning the existing XML tests and adjusting them for JSON would be a good start.</p>
<p dir="auto">Does CONTRIBUTING.md not explain what you need to know?</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5943#discussion_r2054545944">app/controllers/api/traces_controller.rb</a>:</p>
<pre style='color:#555'>> +        respond_to do |format|
+          format.xml { render :content_type => "application/xml" }
+          format.json { render :content_type => "application/json" }
+        end
</pre>
<p dir="auto">I don't think you need the explicit content type here. I think this will suffice:</p>
⬇️ Suggested change
<pre style="color: #555">-        respond_to do |format|
-          format.xml { render :content_type => "application/xml" }
-          format.json { render :content_type => "application/json" }
-        end
+        respond_to do |format|
+          format.xml
+          format.json
+        end
</pre>


<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5943#discussion_r2054546382">app/controllers/api/users/traces_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -7,7 +7,10 @@ class TracesController < ApiController
 
       def index
         @traces = current_user.traces.reload
-        render :content_type => "application/xml"
+        respond_to do |format|
+          format.xml { render :content_type => "application/xml" }
+          format.json { render :content_type => "application/json" }
+        end
</pre>
<p dir="auto">Same goes here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5943#pullrequestreview-2784818932">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJKZZPG4JYGC7BRZPL22Z4CBAVCNFSM6AAAAAB3R7L6LOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOBUHAYTQOJTGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNCJ4DDAEPRIULFVTT22Z4CBA5CNFSM6AAAAAB3R7L6LOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVF7T3PI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5943/review/2784818932</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5943#pullrequestreview-2784818932",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5943#pullrequestreview-2784818932",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>