<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<blockquote>
<p dir="auto">After implementing removing special comments (ones with non-present body) in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2976793574" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5904" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5904/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5904">#5904</a> (which contains all functionaliti , I realized we need to keep <code class="notranslate">note comment's visibility</code> (so we could hide note comment after deleting special comments)</p>
</blockquote>
<p dir="auto">After short thought, perhaps we don't need to control visibility of special note comments with non-present body(?) so, I removed <code class="notranslate">note_comment_visible</code> record from <code class="notranslate">note_versions</code> to keep table as small as possible.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2822562162">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO77F5KQIZCWPEOKJ322222VAVCNFSM6AAAAABZFBY7WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRSGU3DEMJWGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMXGZSXAPHBMIZ6WJD22222VA5CNFSM6AAAAABZFBY7WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVIHTQXE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5815/c2822562162</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/25298521?s=20&v=4" /><strong>nenad-vujicic</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2822562162">(openstreetmap/openstreetmap-website#5815)</a></div>
<blockquote>
<p dir="auto">After implementing removing special comments (ones with non-present body) in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2976793574" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5904" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5904/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5904">#5904</a> (which contains all functionaliti , I realized we need to keep <code class="notranslate">note comment's visibility</code> (so we could hide note comment after deleting special comments)</p>
</blockquote>
<p dir="auto">After short thought, perhaps we don't need to control visibility of special note comments with non-present body(?) so, I removed <code class="notranslate">note_comment_visible</code> record from <code class="notranslate">note_versions</code> to keep table as small as possible.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2822562162">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO77F5KQIZCWPEOKJ322222VAVCNFSM6AAAAABZFBY7WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRSGU3DEMJWGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMXGZSXAPHBMIZ6WJD22222VA5CNFSM6AAAAABZFBY7WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVIHTQXE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5815/c2822562162</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2822562162",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2822562162",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>