<p></p>
<p><b>@hlfan</b> approved this pull request.</p>
<p dir="auto">Looks good, only noted some minor ideas</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5943#discussion_r2056936086">app/controllers/api/traces_controller.rb</a>:</p>
<pre style='color:#555'>> + if @trace.public? || @trace.user == current_user
+ respond_to do |format|
+ format.xml
+ format.json
+ end
+ else
+ head :forbidden
+ end
</pre>
⬇️ Suggested change
<pre style="color: #555">- if @trace.public? || @trace.user == current_user
- respond_to do |format|
- format.xml
- format.json
- end
- else
- head :forbidden
- end
+ return head :forbidden unless @trace.public? || @trace.user == current_user
+
+ respond_to do |format|
+ format.xml
+ format.json
+ end
</pre>
<p dir="auto">I'd keep the <code class="notranslate">head :forbidden unless</code> guard clause from before</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5943#discussion_r2056936987">test/controllers/api/users/traces_controller_test.rb</a>:</p>
<pre style='color:#555'>> + assert_equal trace1.id, js["traces"][0]["id"]
+ assert_equal trace2.id, js["traces"][1]["id"]
</pre>
<p dir="auto">I'd like to see the tags being checked like for the XML here too</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5943#pullrequestreview-2788783045">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJFB3R6I3XG6CAXXRD23AGSVAVCNFSM6AAAAAB3R7L6LOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOBYG44DGMBUGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPE5JLKNLQRLRJ5EFT23AGSVA5CNFSM6AAAAAB3R7L6LOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVGHFZ4K.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5943/review/2788783045</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5943#pullrequestreview-2788783045",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5943#pullrequestreview-2788783045",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>