<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r2059430203">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> @@ -121,6 +135,27 @@ OSM = {
return mapParams;
},
+ parseGeoURI: function (geoURI) {
+ if (!geoURI || !URL.canParse(geoURI)) return;
+ const url = new URL(geoURI);
+ if (url.protocol !== "geo:" || !url.pathname) return;
+ const [path, ...params] = url.pathname.split(";");
+ let coords;
+ try {
+ coords = L.latLng(path.split(","));
+ } catch { return; }
+ if (!coords) return;
+ const searchParams = new URLSearchParams(params.join("&"));
+ const crs = searchParams.get("crs");
+ if (crs && crs !== "wgs84") return;
+ const uncertainty = parseFloat(searchParams.get("u"));
</pre>
<p dir="auto">This still won't work correctly because geo params are case insensitive. But the fix should be easy, just convert the entire geo uri to lowercase.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2792801698">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ53TUTDRI4XEXFO2T23GEW5AVCNFSM6AAAAABYDP55XWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOJSHAYDCNRZHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIEW5VIBXWH6LNFO7L23GEW5A5CNFSM6AAAAABYDP55XWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVGO3C2E.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5736/review/2792801698</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2792801698",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2792801698",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>