<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r2060446192">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> @@ -121,6 +135,30 @@ OSM = {
return mapParams;
},
+ parseGeoURI: function (geoURI) {
+ if (typeof geoURI !== "string") return;
+ let url;
+ try {
+ url = new URL(geoURI.toLowerCase());
+ } catch (e) { return; }
+ if (url.protocol !== "geo:" || !url.pathname) return;
+ const [path, ...params] = url.pathname.split(";");
+ let coords;
+ try {
+ coords = L.latLng(path.split(","));
+ } catch (e) { return; }
+ if (!coords) return;
+ const searchParams = new URLSearchParams(params.join("&"));
</pre>
<p dir="auto">I checked Google Maps and looks like <code class="notranslate">z</code> is case sensitive, so it's better to move <code class="notranslate">toLowerCase</code> here:</p>
⬇️ Suggested change
<pre style="color: #555">- const searchParams = new URLSearchParams(params.join("&"));
+ const searchParams = new URLSearchParams(params.join("&").toLowerCase());
</pre>
<p dir="auto"><code class="notranslate">url.protocol !== "geo:"</code> should still work because the <code class="notranslate">URL</code> class converts it to lowecase on its own.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2794493163">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIX6HE4Y7O6RXVMPQD23JHC7AVCNFSM6AAAAABYDP55XWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOJUGQ4TGMJWGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJMVSUNGKDKNP7Q7LT23JHC7A5CNFSM6AAAAABYDP55XWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVGSCKOW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5736/review/2794493163</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2794493163",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2794493163",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>