<p></p>
<p><b>@hlfan</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5963#discussion_r2067558212">app/assets/javascripts/index/history-changesets-layer.js</a>:</p>
<pre style='color:#555'>> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds, this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds, this._getAreaStyle(changeset));
+ rect.id = changeset.id;
+ rect.addTo(this._areaLayer);
+ }
+
+ for (const changeset of this._changesets.values()) {
+ const rect = L.rectangle(changeset.bounds, this._getBorderStyle(changeset));
</pre>
<p dir="auto">But at that stage you don't need the changeset reference anymore.</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"><span class="pl-k">const</span> <span class="pl-s1">changesetAreas</span> <span class="pl-c1">=</span> <span class="pl-kos">[</span><span class="pl-kos">]</span><span class="pl-kos">;</span>
<span class="pl-k">const</span> <span class="pl-s1">changesetBorders</span> <span class="pl-c1">=</span> <span class="pl-kos">[</span><span class="pl-kos">]</span><span class="pl-kos">;</span>
<span class="pl-k">for</span> <span class="pl-kos">(</span><span class="pl-k">const</span> <span class="pl-s1">changeset</span> <span class="pl-k">of</span> <span class="pl-smi">this</span><span class="pl-kos">.</span><span class="pl-c1">_changesets</span><span class="pl-kos">.</span><span class="pl-en">values</span><span class="pl-kos">(</span><span class="pl-kos">)</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-k">const</span> <span class="pl-s1">arect</span> <span class="pl-c1">=</span> <span class="pl-v">L</span><span class="pl-kos">.</span><span class="pl-en">rectangle</span><span class="pl-kos">(</span><span class="pl-s1">changeset</span><span class="pl-kos">.</span><span class="pl-c1">bounds</span><span class="pl-kos">,</span> <span class="pl-kos">{</span> <span class="pl-c1">className</span>: <span class="pl-smi">this</span><span class="pl-kos">.</span><span class="pl-en">_getSidebarRelativeClassName</span><span class="pl-kos">(</span><span class="pl-s1">changeset</span><span class="pl-kos">)</span><span class="pl-kos">)</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-k">const</span> <span class="pl-s1">brect</span> <span class="pl-c1">=</span> <span class="pl-v">L</span><span class="pl-kos">.</span><span class="pl-en">rectangle</span><span class="pl-kos">(</span><span class="pl-s1">changeset</span><span class="pl-kos">.</span><span class="pl-c1">bounds</span><span class="pl-kos">,</span> <span class="pl-kos">{</span> <span class="pl-c1">className</span>: <span class="pl-smi">this</span><span class="pl-kos">.</span><span class="pl-en">_getSidebarRelativeClassName</span><span class="pl-kos">(</span><span class="pl-s1">changeset</span><span class="pl-kos">)</span><span class="pl-kos">)</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">arect</span><span class="pl-kos">.</span><span class="pl-c1">id</span> <span class="pl-c1">=</span> <span class="pl-s1">brect</span><span class="pl-kos">.</span><span class="pl-c1">id</span> <span class="pl-c1">=</span> <span class="pl-s1">changeset</span><span class="pl-kos">.</span><span class="pl-c1">id</span><span class="pl-kos">;</span>
<span class="pl-s1">changesetAreas</span><span class="pl-kos">.</span><span class="pl-en">push</span><span class="pl-kos">(</span><span class="pl-s1">arect</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">changesetBorders</span><span class="pl-kos">.</span><span class="pl-en">push</span><span class="pl-kos">(</span><span class="pl-s1">arect</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span>
<span class="pl-s1">changesetAreas</span><span class="pl-kos">.</span><span class="pl-en">forEach</span><span class="pl-kos">(</span><span class="pl-s1">a</span> <span class="pl-c1">=></span> <span class="pl-smi">this</span><span class="pl-kos">.</span><span class="pl-c1">_areaLayer</span><span class="pl-kos">.</span><span class="pl-en">addLayer</span><span class="pl-kos">(</span><span class="pl-s1">a</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">changesetBorders</span><span class="pl-kos">.</span><span class="pl-en">forEach</span><span class="pl-kos">(</span><span class="pl-s1">b</span> <span class="pl-c1">=></span> <span class="pl-smi">this</span><span class="pl-kos">.</span><span class="pl-c1">_borderLayer</span><span class="pl-kos">.</span><span class="pl-en">addLayer</span><span class="pl-kos">(</span><span class="pl-s1">b</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-smi">this</span><span class="pl-kos">.</span><span class="pl-c1">_areaLayer</span><span class="pl-kos">.</span><span class="pl-en">setStyle</span><span class="pl-kos">(</span><span class="pl-kos">{</span>
<span class="pl-c1">weight</span>: <span class="pl-c1">0</span><span class="pl-kos">,</span>
<span class="pl-c1">fillOpacity</span>: <span class="pl-c1">0</span>
<span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-smi">this</span><span class="pl-kos">.</span><span class="pl-c1">_borderLayer</span><span class="pl-kos">.</span><span class="pl-en">setStyle</span><span class="pl-kos">(</span><span class="pl-kos">{</span>
<span class="pl-c1">weight</span>: <span class="pl-c1">2</span><span class="pl-kos">,</span>
<span class="pl-c1">color</span>: <span class="pl-s">"var(--changeset-border-color)"</span><span class="pl-kos">,</span>
<span class="pl-c1">fill</span>: <span class="pl-c1">false</span>
<span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p dir="auto">No get...Style wrappers around _getSidebarRelativeClassName needed.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5963#pullrequestreview-2805284149">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOVOVQCTZ2RWAO5P4D24AAORAVCNFSM6AAAAAB4DDCHDKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMBVGI4DIMJUHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLK6SES4MP2JMQ6SYDD24AAORA5CNFSM6AAAAAB4DDCHDKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVHGU6TK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5963/review/2805284149</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5963#pullrequestreview-2805284149",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5963#pullrequestreview-2805284149",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>