<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2071930286">app/views/notes/index.html.erb</a>:</p>
<pre style='color:#555'>> @@ -26,6 +26,10 @@
 <% else %>
   <%= render :partial => "notes_paging_nav" %>
 
+  <svg width="0" height="0" class="end-100 position-absolute">
</pre>
<p dir="auto">As all three places that include the partial wrap it in the same <code class="notranslate">svg</code> element why not include that in the partial?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2071931247">app/views/notes/index.html.erb</a>:</p>
<pre style='color:#555'>> @@ -26,6 +26,10 @@
 <% else %>
   <%= render :partial => "notes_paging_nav" %>
 
+  <svg width="0" height="0" class="end-100 position-absolute">
+    <%= render :partial => "layouts/defs_markers", :locals => { :types => %w[cross tick] } %>
</pre>
<p dir="auto">What's the logic behind <code class="notranslate">defs_markers</code> as the name? I assume defs is definitions or something? I suggest just using <code class="notranslate">markers</code> as the name I think.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-2812545336">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK53GONLQWDAWJQQT324OTOXAVCNFSM6AAAAABZ4WJVUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMJSGU2DKMZTGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKY4IWIW3QDUCS3FXT24OTOXA5CNFSM6AAAAABZ4WJVUSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVHUQETQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5854/review/2812545336</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-2812545336",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-2812545336",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>