<p dir="auto">Folows <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3030066569" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5965" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5965/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5965">#5965</a>. Finishes API changeset resources refactor.</p>
<p dir="auto">Converts <a href="https://wiki.openstreetmap.org/wiki/API_v0.6#Diff_upload:_POST_/api/0.6/changeset/#id/upload" rel="nofollow">diff upload</a> action of api changeset controller into its own recource/controller.</p>
<p dir="auto">The PR consists mostly of moving and rewriting tests.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5977'>https://github.com/openstreetmap/openstreetmap-website/pull/5977</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/bfef57f2ac82c9a59a372228f6b2c47545166384" class="commit-link">bfef57f</a> Create api changeset upload resource</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/a0c0ce1428cc03bb1f648e803895f4d7d0b72b09" class="commit-link">a0c0ce1</a> Remove unnecessary RuboCop exclusions</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/c0dde875d4949f9615ee34d19486fd481e9f0b33" class="commit-link">c0dde87</a> Move api changeset upload route test</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/54b5b80183c14c923891b5218f05bbcc4f9eef3a" class="commit-link">54b5b80</a> Split and move api changeset test_upload_simple_valid</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/40724cbf6a7dfe47f1120cd90f35c7a7cc90563f" class="commit-link">40724cb</a> Test scopes for api changeset upload</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/3d240ef75fc8ea35355233c3d3f947edf30f6499" class="commit-link">3d240ef</a> Move api changeset upload create tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/231f0837346118d5f2ddecb2e0637849be3f1b22" class="commit-link">231f083</a> Move api changeset upload delete tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/4f94a56d9ee8c8d284d3e12b8eac84631fecc3fa" class="commit-link">4f94a56</a> Move api changeset upload modify tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/fb493cde5806ca2ed7fd381429ce505769b67d00" class="commit-link">fb493cd</a> Move api changeset upload unknown action test</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/2239fb320d61d2404b82ba75dc8d20ad2868c6be" class="commit-link">2239fb3</a> Move api changeset upload combined action tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/948d5e2e36b79114772f2f0e8f40cd49f8ae8e3e" class="commit-link">948d5e2</a> Move api empty changeset upload test</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/326bdb2d1adc7050644a95711dcdc4402a4b18ba" class="commit-link">326bdb2</a> Move api changeset upload xml error test</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/fb72adf410f5f58ff304a582d5879d354e746718" class="commit-link">fb72adf</a> Refactor api changeset test_upload_not_found</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/99d386bda1d130e563ee58eedea09b678d9db948" class="commit-link">99d386b</a> Move api changeset upload rate/size limit tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/3f6aeb1918069bb1c8b6796f97632183c3a6049b" class="commit-link">3f6aeb1</a> Move api changeset upload bbox tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/commits/6482d373bebab09547b5f0067688af576fbedef3" class="commit-link">6482d37</a> Move api changeset upload-download tests</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files">9 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-4f894049af3375c2bd4e608f546f8d4a0eed95464efcdea850993200db9fef5c">.rubocop.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-341a1cf4f83cf00816b397c262181cd7b229f1c0e9210ba57dcef3f9609c1b74">app/abilities/api_ability.rb</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-825c845680d997c93f815c71d78ab9b50774598b0dbed385d0051f887278e7e8">app/controllers/api/changesets/uploads_controller.rb</a>
(44)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-6726f8601cd22886963fb41888b55956cae4f8124aa12c701da77c3add44d94c">app/controllers/api/changesets_controller.rb</a>
(37)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(9)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-f6fe2132aae5ac6c27fa66034cfc7a48d8a6d04e0084c4b147053396123e988c">test/controllers/api/changesets/uploads_controller_test.rb</a>
(1370)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-e95198c7f7744be3ce9857db36d2374538ca7d64caaf0f6f85865d6752563ee9">test/controllers/api/changesets_controller_test.rb</a>
(1541)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-da8c6d0ce9e50a5d0d4517cb17a60cc0df2f286b573ea8132fd903ad8c227237">test/controllers/api/relations_controller_test.rb</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977/files#diff-ce232354b8ca09f3c326e1713cd6921863d63e502181002bca46d059ef0a1a9e">test/integration/changeset_upload_download_test.rb</a>
(177)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5977.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5977.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5977.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5977.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5977">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOMLLBSAEBUU6CA2AT24V2RLAVCNFSM6AAAAAB4MLMXCSVHI2DSMVQWIX3LMV43ASLTON2WKOZTGAZTONZSGUZDONY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLL73Y3XG2SMDQICR3324V2RLA5CNFSM6AAAAAB4MLMXCSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHLKEACLU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5977</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5977",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5977",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>