<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5887#discussion_r2075963146">app/helpers/geocoder_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -23,6 +23,12 @@ def result_to_html(result)
     safe_join(html)
   end
 
+  def map_hash(params)
+    return "" unless params[:lat].present? && params[:lon].present?
+
+    "#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}"
</pre>
<p dir="auto">Why do we need to convert lat and lon to floating point and then immediately back to string again?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5887#discussion_r2075967172">app/views/site/welcome.html.erb</a>:</p>
<pre style='color:#555'>> @@ -81,7 +81,8 @@
 <% if params[:oauth_return_url] %>
   <a class="btn btn-primary" href="<%= params[:oauth_return_url] %>"><%= t ".continue_authorization" %></a>
 <% else %>
-  <a class="btn btn-primary start-mapping" href="<%= edit_path %>"><%= t ".start_mapping" %></a>
+  <%= editor_query = "?editor=#{params[:editor].to_s.split(/\W/)[0]}" if params[:editor].present?
</pre>
<p dir="auto">Why do we need to split the editor into words and then just take the first one? The javascript implementation that this is replacing doesn't seem to do that?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5887#pullrequestreview-2819123248">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOPUESUPU2XI7WFOAL25DXWJAVCNFSM6AAAAAB2OIGNS6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMJZGEZDGMRUHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMSVAK3JKGIFLB6MZD25DXWJA5CNFSM6AAAAAB2OIGNS6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVIBBUDA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5887/review/2819123248</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5887#pullrequestreview-2819123248",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5887#pullrequestreview-2819123248",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>