<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/76796906?s=20&v=4" /><strong>kcne</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5906#issuecomment-2875086838">(openstreetmap/openstreetmap-website#5906)</a></div>
<p dir="auto">Thanks everyone for the valuable feedback.</p>
<p dir="auto">I completely understand the concerns around code complexity. My initial intent was to address the visual inconsistency of showing "empty" days beyond today’s date and to ensure proper localization of week starts — something users from different locales will appreciate. I agree that this resulted in more manual code than ideal, especially after trying to avoid CSP issues introduced by the plugin.</p>
<p dir="auto">Regarding the domain naming: it's a bit misleading, I agree. I’m could rename it to something more accurate, like daysYearlyDomain, to better reflect its structure and avoid confusion.</p>
<p dir="auto">I also noticed the alternative PR (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3054031396" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5998" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5998/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5998">#5998</a>), which, to be honest, is a much simpler approach that achieves the same goal. I’m open to closing this in favor of merging the better solution, even though I’ve spent quite a bit of time working through this.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5906#issuecomment-2875086838">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNOFOS23BVS7YLXYL326F645AVCNFSM6AAAAAB2VRVDVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZVGA4DMOBTHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP7EBQOPGMWQDNIJUT26F645A5CNFSM6AAAAAB2VRVDVGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVLLZL7M.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5906/c2875086838</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5906#issuecomment-2875086838",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5906#issuecomment-2875086838",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>