<p></p>
<p><b>@1ec5</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2086125665">app/views/shared/_language_selector.html.erb</a>:</p>
<pre style='color:#555'>> +    <select role="button" class="p-0 position-absolute top-0 start-0 w-100 h-100 language-change-trigger text-transparent bg-transparent <%= classes %>">
+      <% Locale.available
+               .select { |locale| I18n.exists? "shared.language_selector.#{locale}" }
+               .sort_by { |locale| t(".#{locale}") }
+               .each do |locale| %>
+        <option class="form-select" value="<%= locale.to_s %>" <%= "selected" if I18n.locale.to_s == locale.to_s %>><%= t(".#{locale}") %></option>
+      <% end %>
+    </select>
</pre>
<p dir="auto">Do we need to generate this menu statically? If we can rely on JavaScript to generate the labels, then <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DisplayNames" rel="nofollow"><code class="notranslate">Intl.DisplayNames</code></a> would save our translators the burden of translating all these language names yet again. (Or you could use the same API to preserve each language’s name for itself.) For example, <a href="https://github.com/osm-americana/openstreetmap-americana/blob/7fe7232d102e309e2398c719eedcc294220c39cc/src/js/language_label.js#L39-L114">here’s how OpenStreetMap Americana</a> generates its language selector. If JavaScript is disabled or the browser doesn’t support this API, we could fall back to ISO 639 codes or a text field.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2835595164">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMNSX2EGZEG5QB2YMD26GN4LAVCNFSM6AAAAABODAIFFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZVGU4TKMJWGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLFOZ2F5KSBHMS2WNT26GN4LA5CNFSM6AAAAABODAIFFCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVJAO7ZY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5201/review/2835595164</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2835595164",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2835595164",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>