<p></p>
<p><b>@rkoeze</b> commented on this pull request.</p>
<p dir="auto">Looks great. Left a couple of comments.</p>
<p dir="auto">I wonder if there's an opportunity to use some of these design elements on the <code class="notranslate">/diaries</code> page.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r2089891239">app/views/diary_entries/_profile_diaries.html.erb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <h5 class="mt-4 mb-3"><%= t(".recent_diaries") %></h5>
</pre>
<p dir="auto">Would it make sense to style the "Recent Diaries" string so that it's consistent with the "x contributions in the last year" string?</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r2089894706">app/views/diary_entries/_profile_diaries.html.erb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <h5 class="mt-4 mb-3"><%= t(".recent_diaries") %></h5>
+ <div class="row row-cols-1 row-cols-md-2 g-4 mb-4">
+ <% diary_entries.each do |entry| %>
+ <div class="col profile-diary-card">
+ <div class="card h-100">
+ <div class="card-body d-flex flex-column">
+ <p class="card-title">
+ <%= image_tag "note.svg", :class => "card-icon", :alt => "Note" %>
+ <%= link_to entry.title, diary_entry_path(@user, entry) %>
+ </p>
+ <p class="card-text flex-grow-1"><%= truncate(strip_tags(entry.body.to_html), :length => 150) %></p>
+
+ <div class="card-text d-flex justify-content-between align-items-center mt-auto">
+ <small class="text-body-secondary">
</pre>
<p dir="auto">On the <code class="notranslate">/diary</code> page we make the <code class="notranslate">x comments</code> string a clickable link that takes the user to the comment section of the post. We could also do that here.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r2089903357">app/views/diary_entries/_profile_diaries.html.erb</a>:</p>
<pre style='color:#555'>> + <% diary_entries.each do |entry| %>
+ <div class="col profile-diary-card">
+ <div class="card h-100">
+ <div class="card-body d-flex flex-column">
+ <p class="card-title">
+ <%= image_tag "note.svg", :class => "card-icon", :alt => "Note" %>
+ <%= link_to entry.title, diary_entry_path(@user, entry) %>
+ </p>
+ <p class="card-text flex-grow-1"><%= truncate(strip_tags(entry.body.to_html), :length => 150) %></p>
+
+ <div class="card-text d-flex justify-content-between align-items-center mt-auto">
+ <small class="text-body-secondary">
+ <%= image_tag "comment.svg", :class => "card-icon", :alt => "Comments" %> <%= entry.comments.size %> <%= "comment".pluralize(entry.comments.size) %>
+ </small>
+ <small class="text-body-secondary">
+ <%= image_tag "calendar.svg", :class => "card-icon", :alt => "Date" %> <%= l(entry.created_at.to_date, :format => :long) %>
</pre>
<p dir="auto">The date string and icon don't look like they're aligned vertically. Same thing for the comments. Maybe they're not intended to be. If so ignore!</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r2089899217">app/views/diary_entries/_profile_diaries.html.erb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <h5 class="mt-4 mb-3"><%= t(".recent_diaries") %></h5>
+ <div class="row row-cols-1 row-cols-md-2 g-4 mb-4">
+ <% diary_entries.each do |entry| %>
+ <div class="col profile-diary-card">
+ <div class="card h-100">
+ <div class="card-body d-flex flex-column">
+ <p class="card-title">
+ <%= image_tag "note.svg", :class => "card-icon", :alt => "Note" %>
+ <%= link_to entry.title, diary_entry_path(@user, entry) %>
+ </p>
+ <p class="card-text flex-grow-1"><%= truncate(strip_tags(entry.body.to_html), :length => 150) %></p>
+
+ <div class="card-text d-flex justify-content-between align-items-center mt-auto">
+ <small class="text-body-secondary">
</pre>
<p dir="auto">Although on second thought we don't show very much of the message so that would very much mean we are enabling people to comment before reading!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6010#pullrequestreview-2841715448">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK365JCG42MPJAFJR326PHEXAVCNFSM6AAAAAB47YBI32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNBRG4YTKNBUHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLLY72I3BFNUOWSUNL26PHEXA5CNFSM6AAAAAB47YBI32WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVJMERPQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6010/review/2841715448</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6010#pullrequestreview-2841715448",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6010#pullrequestreview-2841715448",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>