<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6018#discussion_r2094125689">app/controllers/users_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -2,6 +2,7 @@ class UsersController < ApplicationController
include EmailMethods
include SessionMethods
include UserMethods
+ include HeatmapHelper
</pre>
<p dir="auto">This should probably be a <code class="notranslate">HeatmapMethods</code> concern rather than a helper - helpers are primarily about adding methods to view, where they are made available automatically, while concerns are about extending models and controllers.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6018#pullrequestreview-2848284315">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO25BWEAMRTP4AESZD26435XAVCNFSM6AAAAAB5J3PW6OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNBYGI4DIMZRGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJYTDAG3SET3A7T75T26435XA5CNFSM6AAAAAB5J3PW6OWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVJYVPJW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6018/review/2848284315</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6018#pullrequestreview-2848284315",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6018#pullrequestreview-2848284315",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>