<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5829#discussion_r2098179147">test/controllers/users_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :success
     # The data should not be empty
     heatmap_data = assigns(:heatmap_data)
     assert_not_nil heatmap_data
     assert_predicate heatmap_data[:data], :any?
     # The data should be in the right format
-    assert(heatmap_data[:data].values.all? { |entry| entry[:date] && entry[:total_changes] }, "Heatmap data should have :date and :total_changes keys")
+    assert(heatmap_data[:data].values.all? { |entry| entry[:date] && entry[:total_changes] && entry[:max_id] }, "Heatmap data should have :date and :total_changes keys")
</pre>
<p dir="auto">Do wee need to keep that comment or is "incorrect heatmap data structure" enough?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5829#pullrequestreview-2854524953">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLM2BPKBKI4ETTBRMT27M6BLAVCNFSM6AAAAABZOVRU6CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNJUGUZDIOJVGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNUAPBXEJ4UWMFTPO327M6BLA5CNFSM6AAAAABZOVRU6CWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVKESMBS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5829/review/2854524953</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5829#pullrequestreview-2854524953",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5829#pullrequestreview-2854524953",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>