<h3 dir="auto">Description</h3>
<p dir="auto"><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #6020.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3070577776" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6020" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/6020/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/6020">#6020</a></p>
<h3 dir="auto">How has this been tested?</h3>
<p dir="auto">Scenarios tested on local instance:</p>
<ol dir="auto">
<li>GitHub as single third party provider</li>
</ol>
<ul dir="auto">
<li>Log in / Sign up</li>
<li>Change external authentication on "My Account" from "Github" to "None", and back to "Github", check log in process</li>
</ul>
<ol start="2" dir="auto">
<li>No third party providers configured</li>
</ol>
<ul dir="auto">
<li>Check that UI doesn't mention "or log in with a third party" along with an empty list of third party providers</li>
</ul>
<p dir="auto">Open issues:</p>
<ul dir="auto">
<li>
<p dir="auto">app/assets/javascripts/auth_providers.js seems to have a timing issue on /user/new page. Previously, the auth provider pointed to /auth/github?referer=undefined. I added a fallback to replace undefined by an empty string. It would probably make sense to call this code from app/assets/javascripts/user.js in some different way. Please comment with suggestions for improvement.</p>
</li>
<li>
<p dir="auto">I couldn't find out how to test <code class="notranslate">preferred_auth_provider</code>. Is this parameter documented somewhere?</p>
</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/6038'>https://github.com/openstreetmap/openstreetmap-website/pull/6038</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/commits/42f4bfc9e341d20275c6a096167acb9cc39a2f49" class="commit-link">42f4bfc</a> Remove legacy OpenID login</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files">18 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-d09ea66f8227784ff4393d88a19836f321c915ae10031d16c93d67e6283ab55f">Gemfile</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731f">Gemfile.lock</a>
(8)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-816703b409baf7b7de4ab7d669cc218fb5ab4ea978beb420395d17bbf133fdb8">app/assets/images/auth_providers/openid.svg</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-4218c327342777c9de158b4e68cf4c6ef8e5b10cbb8f6aaf4944705d221821ab">app/assets/javascripts/auth_providers.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-6bf5e2b503c6238cb80234a21524267bec1b1a820855412a5795c6296f11cb89">app/assets/javascripts/user.js</a>
(34)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-25fe163085ea55de795324d01f141d5e4de00c6a2d3035d75c6e0768af679a2e">app/controllers/accounts_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-8ac25145a80d1093fb7a8f1098aa9d5b0a1d70ced7333342a9ec569227d0a82f">app/controllers/concerns/session_methods.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-e01fad846663c1f683b6469fec261f8b186c504c67f5f345aa8bd42837b67c5d">app/views/accounts/show.html.erb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-5a9b0e7aa9d3862ba8103db51b8b44b6e392cb43f22bba850bf95e0be7b53e4f">app/views/application/_auth_providers.html.erb</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-5654cfc158c888a40321c1e90f9ea3a0208ae80616b15ff0fa5e939b8f795e87">app/views/sessions/new.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-8dd599ea27028815c7fa912755a38dd05e4a768470cc792840b85fd1e486d69a">app/views/users/new.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-84ed1be2c135a8c628a3fb258e88c059ae24b3cb90abce9b5a5f74e96eb5c7ee">config/initializers/omniauth.rb</a>
(19)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-42ba58b2050212a385282d51fd9edfd64ef3ad90633f6e8ea9359137d0128a15">lib/auth.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-263ed824209c1bdac16306014aa0ce3a15f026e6095b1b16ecc673c59c9a9eb1">test/integration/login_test.rb</a>
(142)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-19aa16b7c7e0598a9b16e64733cafc53ac88bc34c658524342c0a0bffde8affc">test/integration/user_creation_test.rb</a>
(126)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038/files#diff-6ce22050f5e780d3715895a102269999b084f36b58629e519f09e0b1ce969966">test/system/user_login_test.rb</a>
(14)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6038.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/6038.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6038.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/6038.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLM3EIJTETF6IZN6I3327XTNVAVCNFSM6AAAAAB5WMELHCVHI2DSMVQWIX3LMV43ASLTON2WKOZTGA4DGNZVGE4DQMY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIIL6OA6RXRNLOYEMD27XTNVA5CNFSM6AAAAAB5WMELHCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHLPTSRZM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6038</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6038",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6038",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>