<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3429#discussion_r2106266400">app/controllers/traces_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -33,7 +34,7 @@ def index
elsif current_user && current_user == target_user
t ".my_gps_traces"
else
- t ".public_traces_from", :user => target_user.display_name
+ t ".public_traces_from_html", :user => tag.bdi(target_user.display_name)
</pre>
<p dir="auto">So I've failed to find out exactly what's going on here but something deep in the rails output capture magic is going wrong and causing most of the output inside the <code class="notranslate">tag.head</code> block in <code class="notranslate">app/views/layouts/_head.html.erb</code> to be output directly instead of being captured and then wrapped in the tag.</p>
<p dir="auto">It turns out that <code class="notranslate">bdi</code> tags in a title element don't work anyway though as the browser will just render them as text in the title bar, so I've replaced them with the equivalent unicode characters which is a trick we already use in <code class="notranslate">set_title</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3429#discussion_r2106266400">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN2DC33VQUDDBCXISL3AH7RXAVCNFSM6AAAAABZRCX4QWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNRWHEYDQNZZGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLKUNOA7F2UBVD3WHD3AH7RXA5CNFSM6AAAAABZRCX4QWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVK4GHHW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3429/review/2866908795</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3429#discussion_r2106266400",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3429#discussion_r2106266400",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>