<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038#discussion_r2106273639">app/views/accounts/show.html.erb</a>:</p>
<pre style='color:#555'>> @@ -24,9 +24,8 @@
                    :include_blank => t("auth.providers.none"),
                    :hide_label => true,
                    :wrapper => { :class => "col-auto mb-0" } %>
-      <%= f.text_field(:auth_uid, :hide_label => true, :wrapper => { :class => "col mb-0" }) %>
+      <%= f.hidden_field(:auth_uid, :hide_label => true, :wrapper => { :class => "col mb-0" }) %>
</pre>
<p dir="auto">I suspect we don't actually need this field any more - it was only there to allow the UID to be edited when OpenID was in use and for other methods users shouldn't be changing the UID so I think just leaving it out will be fine.</p>
<p dir="auto">We would need to change the <code class="notranslate">update</code> method in <code class="notranslate">AccountsController</code> to stop comparing the uid for equality and then including it in the redirect but we probably want to do the second part anyway as it's only there for openid.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038#pullrequestreview-2866914841">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN3YHYIHI35IYLWXXL3AIDP7AVCNFSM6AAAAAB5WMELHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNRWHEYTIOBUGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOPW73W47A2QZH4TQ33AIDP7A5CNFSM6AAAAAB5WMELHCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVK4GTBS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6038/review/2866914841</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6038#pullrequestreview-2866914841",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6038#pullrequestreview-2866914841",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>