<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038#discussion_r2106259273">app/views/application/_auth_providers.html.erb</a>:</p>
<pre style='color:#555'>>        <% end -%>
     </div>
   <% end %>
-
-  <%# :tabindex starts high to allow rendering at the bottom of the template %>
-  <%= form_tag auth_path(:provider => "openid"), :id => "openid_login_form", :class => "collapse" do %>
-    <div class="mb-3">
-      <label for="openid_url" class="form-label">
-        <%= image_tag "auth_providers/openid.svg", :size => "36", :alt => "", :class => "align-text-bottom" %>
-        <%= t ".openid_url" %>
-      </label>
-      <%= hidden_field_tag("referer", params[:referer], :autocomplete => "off") %>
</pre>
<p dir="auto">Ok, I think I know what's going on. We used to have the same "referer" field twice on the /user/new page, once on the openid form (this line), and another time as field  in the "new_user" form:   <code class="notranslate"><%= hidden_field_tag("referer", h(@referer)) unless @referer.nil? %></code> (new.html.erb).</p>
<p dir="auto">Since the field in the openid form was always present, auth_providers.js never returned "undefined". Now that we're removing this form, this assumption no longer holds true.</p>
<p dir="auto">So the change in auth_providers.js to have an empty string as fallback should be backwards compatible. Previously, the "auth buttons" always had a referer URL parameter, even if the value was an empty string.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6038#pullrequestreview-2866902599">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKCJFLWOKDJ7LUZ6633AH3XJAVCNFSM6AAAAAB5WMELHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNRWHEYDENJZHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOHCAJ74VRAJJ7ILFT3AH3XJA5CNFSM6AAAAAB5WMELHCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVK4F3EO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6038/review/2866902599</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6038#pullrequestreview-2866902599",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6038#pullrequestreview-2866902599",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>