<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2121255541">app/views/shared/_language_selector.html.erb</a>:</p>
<pre style='color:#555'>> + <select role="button" class="p-0 position-absolute top-0 start-0 w-100 h-100 language-change-trigger text-transparent bg-transparent <%= classes %>">
+ <% Locale.available
+ .select { |locale| I18n.exists? "shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+ <option class="form-select" value="<%= locale.to_s %>" <%= "selected" if I18n.locale.to_s == locale.to_s %>><%= t(".#{locale}") %></option>
+ <% end %>
+ </select>
</pre>
<p dir="auto">After <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3070971551" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6024" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/6024/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/6024">#6024</a> this can be replaced with</p>
⬇️ Suggested change
<pre style="color: #555">- <select role="button" class="p-0 position-absolute top-0 start-0 w-100 h-100 language-change-trigger text-transparent bg-transparent <%= classes %>">
- <% Locale.available
- .select { |locale| I18n.exists? "shared.language_selector.#{locale}" }
- .sort_by { |locale| t(".#{locale}") }
- .each do |locale| %>
- <option class="form-select" value="<%= locale.to_s %>" <%= "selected" if I18n.locale.to_s == locale.to_s %>><%= t(".#{locale}") %></option>
- <% end %>
- </select>
+ <%= select_tag "language",
+ options_for_select(AVAILABLE_LANGUAGES.map { |e| [e[:native_name], e[:code]] },
+ I18n.locale),
+ :role => "button",
+ :class => "p-0 position-absolute top-0 start-0 w-100 h-100 language-change-trigger text-transparent bg-transparent #{classes}" %>
</pre>
<p dir="auto"><a href="https://github.com/AntonKhorev/openstreetmap-website/tree/a/pull/5201">https://github.com/AntonKhorev/openstreetmap-website/tree/a/pull/5201</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2121255541">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNDM76K3X3EDFEU3DL3BRK3PAVCNFSM6AAAAABODAIFFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOBYGU3TKNBYGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJO6WOQXOO3PV3SBST3BRK3PA5CNFSM6AAAAABODAIFFCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVMFQU74.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5201/review/2888575486</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2121255541",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2121255541",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>