<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6083#discussion_r2123787014">app/assets/javascripts/edit/id.js.erb</a>:</p>
<pre style='color:#555'>> @@ -37,7 +37,8 @@ $(function () {
   id.attr("src", idData.url + "#" + params);
 
   id.ready(function () {
-    if (!this.contentWindow.location.href.startsWith(idData.url)) {
+    id.focus();
+    if (this.contentWindow && !this.contentWindow.location.href.startsWith(idData.url)) {
</pre>
<p dir="auto">When splitting it out, I'd check for valid chaining until the href instead of just the content window.</p>
⬇️ Suggested change
<pre style="color: #555">-    if (this.contentWindow && !this.contentWindow.location.href.startsWith(idData.url)) {
+    const href = this?.contentWindow?.location?.href;
+    if (href && !href.startsWith(idData.url)) {
</pre>

<p dir="auto">Otherwise this looks good to me.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2892327616">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL373PCBPNRBBQ5P6T3BWOFPAVCNFSM6AAAAAB6PPQYMWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOJSGMZDONRRGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPYXR6Y2FDZDXY3RMT3BWOFPA5CNFSM6AAAAAB6PPQYMWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVMMVVMA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6083/review/2892327616</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2892327616",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2892327616",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>