<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6076#discussion_r2147423875">test/javascripts/osm_test.js</a>:</p>
<pre style='color:#555'>> @@ -55,10 +55,10 @@ describe("OSM", function () {
it("parses bbox params", function () {
const expected = L.latLngBounds([57.6247, -3.6845], [57.7247, -3.7845]);
let params = OSM.mapParams("?bbox=-3.6845,57.6247,-3.7845,57.7247");
- expect(params).to.have.property("bounds").deep.equal(expected);
+ expect(L.latLngBounds(params.bounds)).to.deep.equal(expected);
</pre>
<p dir="auto">The test claims to test <code class="notranslate">.mapParams</code>. Why does it need to convert both the expected and the actual value to <code class="notranslate">L.latLngBounds</code> before comparing them?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6076#pullrequestreview-2928959849">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMGWLXNRE7Z2MBKROL3DTZOTAVCNFSM6AAAAAB6LMPY6KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMRYHE2TSOBUHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPS37HG6KE6PV526HD3DTZOTA5CNFSM6AAAAAB6LMPY6KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVOSRQWS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6076/review/2928959849</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6076#pullrequestreview-2928959849",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6076#pullrequestreview-2928959849",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>