<p dir="auto">This PR renames all references to "map key" to "legend" in the codebase, as the term "legend" has less ambiguity and improves clarity.<br>
As an example, <code class="notranslate">(?<!f|foreign|foreign[_ ]|p|primary|primary[_ ]|Settings\.|Object\.|shift|meta|ctrl|alt|api|send_)key(?!board|down|frames)</code> was the regex used to check occurrences of "key", because there have been instances where only "key" was used instead of "map key" or "mapkey".</p>
<p dir="auto">The only exception is the translation source together with the SiteTest and IndexTest, which still use "Map Key". This ensures translatewiki moves the existing translations.<br>
The excessive caching in the controller is also removed, as it has become unnecessary with <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/938212c429a159a1ceeec13b91c4ae966ef6663e/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/938212c429a159a1ceeec13b91c4ae966ef6663e"><tt>938212c</tt></a>.<br>
The <em>panes</em> context has been added to the resource path and the controller name, following discussions in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3100524974" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6063" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/6063/hovercard?comment_id=2973551702&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/6063#issuecomment-2973551702">#6063 (comment)</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3147647764" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6106" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/6106/hovercard?comment_id=2149530329&comment_type=review_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/6106#discussion_r2149530329">#6106 (comment)</a> respectively.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/6113'>https://github.com/openstreetmap/openstreetmap-website/pull/6113</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/7feaab606797728170452e89d5382164b5430462" class="commit-link">7feaab6</a> Remove aggressive caching</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/2cf808ca93ce02edb2ec027ac2283ead95e4591e" class="commit-link">2cf808c</a> Rename map key controller to legend pane</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/4f0715b9ef3b7c635110fbf9ae7f78b51e0b9072" class="commit-link">4f0715b</a> Rename map key element to legend</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/a936a908c7d9ce8d770939cd67cc7a1c928b50bd" class="commit-link">a936a90</a> Rename map key js to legend</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/346e1d27364e9811e3cef3cd80da36b61b4be532" class="commit-link">346e1d2</a> Rename key.yml to legend.yml</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/e847dff3abfe49af3c32d0453c61e2342901e780" class="commit-link">e847dff</a> Rename map key control icon path to legend</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/c8a16a5b7d32ab928aefe839275fbcb72b1c1461" class="commit-link">c8a16a5</a> Rename key_svg_tag to legend_svg_tag in svg_helper</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/4632f1798b3698e53bf92bb312ce6d1c5a7b022a" class="commit-link">4632f17</a> Rename key variable to legend</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/060fc4a251a38dcae68a8f42110c629e70159f8a" class="commit-link">060fc4a</a> Move /key to /panes/legend</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/bf982b9f4df8f8055ebd654a31a70e2d67d619fc" class="commit-link">bf982b9</a> Move legend images from key</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/commits/eaecf9358e94d2ac7e56e9c60e8dfffa52650e37" class="commit-link">eaecf93</a> Move legend js translations</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files">48 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
(2)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-332967b90b1c4ad142f1f349db74e978c9438408463f76c3bb20cca7616b28ae">app/assets/images/legend/cyclemap/beach.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-3b375508b441ace6190c848d602e32dc80c87d03cfa62a1358af1627b9e33dc6">app/assets/images/legend/cyclemap/bicycle_parking.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-6e576d63b10b7dc77c89c63702c65b60a8e9b514062f5894a8c1aaf5e5cb93b5">app/assets/images/legend/cyclemap/bicycle_parking_small.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-2afc63acc248b0ad23c0b3b7d46cdfa8c3b3dfc175095bf8cc32448cc65caeaa">app/assets/images/legend/cyclemap/bicycle_rental.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-d31c2d4a5260281c116fc7768a64d5edbdddce865209a9536b23f5982b5ec8d0">app/assets/images/legend/cyclemap/bicycle_rental_small.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-580d9b9cf4dcb65f81ab4d139f5ac90c909d1e13d1f2bdb7b5b39d16278b34dc">app/assets/images/legend/cyclemap/bicycle_shop.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-1978098843d13e9ac660ba9b1d0d8c5a98c84f9dd8b2b3dd407de6750bc8e801">app/assets/images/legend/cyclemap/toilets.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-1539c8de45cf1b4afb3b57ad2be960e8c6c3f33af3b3ce2a335c60542513a4eb">app/assets/images/legend/mapnik/cable.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-c61d50e48f5f8c6c651a119c11ac6a740a5cc6579459b78fac70e32094624c6e">app/assets/images/legend/mapnik/capital4.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-b2b3b849238844a8b0d5c18fae1a793b77e225515568fce63855c2a5e5721024">app/assets/images/legend/mapnik/capital7.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-0fb49d11d978d0eef8c8957e8f640fedaba01988e8dc371fcc8092cc776288b2">app/assets/images/legend/mapnik/city4.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-be1e3e8082e2643ed48ce613cb6710c01c3604cf18657538a82d6aa34a182b74">app/assets/images/legend/mapnik/city6.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-ab0f0783b52f8b2d3f57a380b9d7f6e096280ca3814be99cb521525443044651">app/assets/images/legend/mapnik/construction.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-23e4217ae478f853fcf87723e0143197d9c6b92446ad6414dc16258b14377ec1">app/assets/images/legend/mapnik/destination.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-a2116f5c9d5a59a19d0f85e64c7a6b593898f38baec3699f9a6091649dbafb54">app/assets/images/legend/mapnik/intermittent_water.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-859989b67bf73a1a330f0d983417037188bf4fcb4033f0ca076fb341f2df779a">app/assets/images/legend/mapnik/mainroad12.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-5de4d8d7b0cd0bfdbe5315d4b74af2fa872df1f2cd5e1a437388c39f368bf088">app/assets/images/legend/mapnik/mainroad15.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-617fac3f50fcf973349f135aef7a833448ba81ab4abf037874d1559b8a755bdc">app/assets/images/legend/mapnik/mainroad8.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-859b814a11e560b30d509f40e8fc36cefabc33f89fc0403832ac00254a70cb8d">app/assets/images/legend/mapnik/mainroad9.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-da8497ab83fb9bce624a18467055c6198e887b110a1a6e33629535e82b065807">app/assets/images/legend/mapnik/military.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-d6c2c980de232cad69ffde804335f08b64ceae280fb323c4865d09a551485c54">app/assets/images/legend/mapnik/private.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-ea6a24353943354290e99051c40ef1b36d913098ae5dee4ecc93fefbf26c325d">app/assets/images/legend/mapnik/reef.png</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-bd306cb6275dced96a1f61e538d4da97e104c3ed5af9e263ff054f84841cd1ac">app/assets/images/legend/mapnik/reserve.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-aa67a4a6a6d0b3cbf5b30338506bed457942748b7163db2bca8b2f15b7f687ba">app/assets/images/legend/mapnik/runway11.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-2f38ccd7e37e5593117e61412a40778d6e9f57bc22912218b116dd288384aa70">app/assets/images/legend/mapnik/runway12.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-54f95ed6cf3180f45bfd4d945321d7cabcc306a0b4fa9b14190f755e2de27355">app/assets/images/legend/mapnik/runway13.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-24246e22ffa0eb31ee815362112b4d94301c17b1e94869319d6c3cfd84782097">app/assets/images/legend/mapnik/runway14.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-2e1270e430cf738bb4e432200ddfcdfa7c68a51bd3768c74835932951f1bb258">app/assets/images/legend/mapnik/school.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-fb9d0865cd938709e5ef30854b2e4125dff3e5a1dde63db750a43f5f5e1ccf77">app/assets/images/legend/mapnik/summit.svg</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-d3980f3248d2ac4e9883b29a9b64c9cd45b0b2163fb4f8895a0d672145eb8c22">app/assets/images/legend/mapnik/wetland.png</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-cdc070ced1c4000efd1e28357fd26b2fd617d7fccfeae0324222231db75dd6ee">app/assets/javascripts/index.js</a>
(4)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-a4565417aa87154876227b646ce8122e5b0c61111e0201218561de74e278fbe4">app/assets/javascripts/leaflet.legend.js</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-c4925852e0efd740fa9486b55efb267e4d1f1984fcdcd3125c5d1784b7a0f7a1">app/assets/javascripts/leaflet.sidebar-pane.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-a9b88a8a3644f944b9bd54361da588c69fa6a210cf7327194c17895a8ad2b0d6">app/assets/javascripts/osm.js.erb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(2)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-ec59830b547ea9704aa74f1f2d671029b8d609697de395059d8e0bc99abe14a1">app/controllers/legend_panes_controller.rb</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-a7200a046015d139f9fe11372e33e7ba1a24250c7866568da5dc13db54f3e33f">app/helpers/svg_helper.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-477473d0a64c6e06edda2c439b3ae2c539039ef3dc9c6c009b554d77f32ec397">app/views/layouts/_control_icons.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-eaeaf6b733bc454c8c41be224e85cdca90bc6e0e5bc1f02f9f86315cfc6fafab">app/views/layouts/map.html.erb</a>
(2)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-b2f47796de9186b7cedffebfe87b3df57cd8b3239a0cf3cdd86065b5dd1d8931">app/views/legend_panes/show.html.erb</a>
(10)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-619b666d7357bef7b692acaf3deec54726c3c11df3baca0303001875c5d381e8">config/legend.yml</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-c97f325f18f3daaf0dd66aa5e5cab276ecbf183f02e716be2be5ee081ee6ea5e">test/controllers/legend_panes_controller_test.rb</a>
(20)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-b8909d2664ad74c5495f380a0b30185c2b46f16442c9137b1224ea7ca9a77655">test/controllers/map_keys_controller_test.rb</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-80d45f6ca8da60fe9db0d037c36f631e03ac43a0307dccefe508f9ae73552eed">test/helpers/svg_helper_test.rb</a>
(44)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113/files#diff-43c6cbf1d8474dfd3889f066ee578a693a1b3ca863f407b07663e0f59102b4ed">test/system/site_test.rb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6113.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/6113.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6113.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/6113.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6113">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKLKCRZCSEUWQKW7TD3D6WJBAVCNFSM6AAAAAB7PFYZISVHI2DSMVQWIX3LMV43ASLTON2WKOZTGE2TEMJYGU3DCMY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMOF6D6ZCCMUE6YW2L3D6WJBA5CNFSM6AAAAAB7PFYZISWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHLXYUJBU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6113</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6113",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6113",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>