<p dir="auto">If the user somehow manages to open <code class="notranslate">/reports/new</code> page without <code class="notranslate">reportable_id</code> and <code class="notranslate">reportable_type</code> parameters, send a bad request error instead of redirection.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/6125'>https://github.com/openstreetmap/openstreetmap-website/pull/6125</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6125/commits/31510d76e9850f5451d899dd9675590730e6551f" class="commit-link">31510d7</a> Replace redirect with bad request error for new report with missing params</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6125/files">4 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6125/files#diff-40c889bfec2f4677ca340d48772b56107986ba517a9cdf5b5852ee1c192f913d">app/controllers/reports_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6125/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6125/files#diff-a88306a3d5206fba4e91b69de7a00d8983ac10c2d26d17ffcf5582dd2ce579a4">test/controllers/reports_controller_test.rb</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6125/files#diff-9f1f22915e6ab6ed93dcabe9188d6288ea0f2e37283bfdff1e9cb79d15bf09b6">test/system/report_diary_entry_test.rb</a>
(6)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6125.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/6125.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6125.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/6125.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6125">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOAYDGOXNNVP22HVDL3E7XKNAVCNFSM6AAAAAB75IG7ZWVHI2DSMVQWIX3LMV43ASLTON2WKOZTGE3DQMBSGIYTGOI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIM36JVUM55XQGD5PT3E7XKNA5CNFSM6AAAAAB75IG7ZWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHLZVBOPM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6125</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6125",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6125",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>